From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again.
Date: Mon, 21 Feb 2011 11:56:29 +0100 [thread overview]
Message-ID: <4D6244DD.4050104@emk-elektronik.de> (raw)
In-Reply-To: <0F3EF05CA2A70E43B140EF090B9F97183EFE01B8@CERNXCHG22.cern.ch>
Dear Uli Raich,
> This version has been tested on an
> armputer-vmax board, which is similar to the at91sam9263ek
> but not on the at91sam9263ek board itself.
> A new configuration "armputer-vmax_config" has been added. This configuration
> has been tested on the hardware and is known to work. Further hardware tests
> for individual options are needed. The LCD screen was not tested.
Sorry, this has to get a full NAK.
1. Please never hijack someone's thread! Your patch has nothing to do with
someone's PATCH 18/18.
2. You are undoing all rework efforts with this patch!
The rework was, amongst others, to get rid of all AT91_*, AT91<SoC>_*, AVR*
macros and unify them into ATMEL_* macros. And by that also remove the twofold
re-wrapping of those defines.
> diff --git a/Makefile b/Makefile
> index 6133160..0c653fa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -827,7 +827,6 @@ at91sam9263ek_norflash_config \
> at91sam9263ek_norflash_boot_config \
> at91sam9263ek_nandflash_config \
> at91sam9263ek_dataflash_config \
> -at91sam9263ek_dataflash_cs0_config \
> at91sam9263ek_config : unconfig
If, all entries have to be moved to boards.cfg
> - at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_BASE_PMC;
> + at91_pmc_t *pmc = (at91_pmc_t *) AT91_PMC_BASE;
ATMEL_BASE_*, ATMEL_ID_* are the new names that are the same names for all ATMEL SoCs,
although they might hold different numerical values.
> - at91_pit_t *pit = (at91_pit_t *) ATMEL_BASE_PIT;
> + at91_pit_t *pit = (at91_pit_t *) AT91_PIT_BASE;
and so on...
> - at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_BASE_PMC;
> - at91_pit_t *pit = (at91_pit_t *) ATMEL_BASE_PIT;
> + at91_pmc_t *pmc = (at91_pmc_t *) AT91_PMC_BASE;
> + at91_pit_t *pit = (at91_pit_t *) AT91_PIT_BASE;
You even re-add white-space errors..
...
> - atmel_usart3_t *usart = (atmel_usart3_t *)CONFIG_USART_BASE;
> + atmel_usart3_t *usart = (atmel_usart3_t*)AT91_DBGU_BASE;
It seems you have not understood the concept of "CONFIG_" macros.
They are to allow the designer to use different USARTs, not
explicitly only the one in the debug unit...
3. And, please, run your patches through checkpatch.pl
Best Regards,
Reinhard
next prev parent reply other threads:[~2011-02-21 10:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 9:41 [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again Uli Raich
2011-02-21 10:56 ` Reinhard Meyer [this message]
2011-02-22 10:34 ` Uli Raich
2011-02-21 10:58 ` Wolfgang Denk
2011-02-21 11:00 ` Remy Bohmer
[not found] ` <4D624A5E.30105@emk-elektronik.de>
2011-02-21 12:53 ` [U-Boot] SoC specific driver changes through other custodian's trees? Wolfgang Denk
2011-02-21 13:35 ` Reinhard Meyer
2011-02-21 13:52 ` Wolfgang Denk
2011-02-21 13:09 ` [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again Andreas Bießmann
2011-02-21 13:17 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6244DD.4050104@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox