From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again.
Date: Mon, 21 Feb 2011 14:09:31 +0100 [thread overview]
Message-ID: <4D62640B.4050804@gmail.com> (raw)
In-Reply-To: <AANLkTimDg7xdPPS0CKUeR2kccy-5drC_6Cizah-cegP8@mail.gmail.com>
Dear Remy Bohmer,
Am 21.02.2011 12:00, schrieb Remy Bohmer:
>> diff --git a/board/atmel/at91sam9263ek/led.c b/board/atmel/at91sam9263ek/led.c
>> index fa1f05b..b3adc51 100644
>> --- a/board/atmel/at91sam9263ek/led.c
>> +++ b/board/atmel/at91sam9263ek/led.c
>> @@ -23,25 +23,22 @@
>> */
>>
>> #include <common.h>
>> -#include <asm/arch/hardware.h>
>> -#include <asm/arch/at91_pmc.h>
>> -#include <asm/arch/at91_pio.h>
>> #include <asm/arch/gpio.h>
>> -#include <asm/arch/io.h>
>> +#include <asm/arch/at91_pmc.h>
>>
>> void coloured_LED_init(void)
>> {
>> /* Enable clock */
>> at91_pmc_t *pmc = (at91_pmc_t *) AT91_PMC_BASE;
>>
>> - writel(1 << AT91SAM9263_ID_PIOB | 1 << AT91SAM9263_ID_PIOCDE,
>> + writel(1 << AT91_ID_PIOB | 1 << AT91_ID_PIOCDE,
>> &pmc->pcer);
>
> Enable all the GPIO peripheral clocks in a board_early_init_f() routine.
> Not here.
No, that is wrong! board_early_init_f() is too late! coloured_LED stuff
is used (currently) in early init stage for debugging. Therefore we need
to initialize the clocks here. Nevertheless it should preserve old
settings in PCER!
If we need these coloured_LED stuff beside the other LED
implementation's is another question.
regards
Andreas Bie?mann
next prev parent reply other threads:[~2011-02-21 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 9:41 [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again Uli Raich
2011-02-21 10:56 ` Reinhard Meyer
2011-02-22 10:34 ` Uli Raich
2011-02-21 10:58 ` Wolfgang Denk
2011-02-21 11:00 ` Remy Bohmer
[not found] ` <4D624A5E.30105@emk-elektronik.de>
2011-02-21 12:53 ` [U-Boot] SoC specific driver changes through other custodian's trees? Wolfgang Denk
2011-02-21 13:35 ` Reinhard Meyer
2011-02-21 13:52 ` Wolfgang Denk
2011-02-21 13:09 ` Andreas Bießmann [this message]
2011-02-21 13:17 ` [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D62640B.4050804@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox