From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] Add support for the MMC device to the vexpress
Date: Fri, 25 Feb 2011 04:02:37 +0100 [thread overview]
Message-ID: <4D671BCD.1090105@emk-elektronik.de> (raw)
In-Reply-To: <1298601325-12112-1-git-send-email-matt.waddel@linaro.org>
Dear matt.waddel at linaro.org,
> From: Matt Waddel<matt.waddel@linaro.org>
>
> These patches add support for the ARM PrimeCell PL180 MultiMedia Interface.
> The Versatile Express was the test platform for these changes.
>
> Matt Waddel (3):
> MMC: Max blocks value adjustable
> MMC: Add support for PL180 ARM mmc device
> ARMV7: Vexpress: Add MMC support
>
> board/armltd/vexpress/ca9x4_ct_vxp.c | 9 +
> drivers/mmc/Makefile | 1 +
> drivers/mmc/mmc.c | 19 +-
> drivers/mmc/mmci.c | 452 ++++++++++++++++++++++++++++++++++
> drivers/mmc/mmci.h | 181 ++++++++++++++
I would expect something more descriptive like <hardware>_mmc.[ch] here.
mmci.[ch] does not lead one to think its a hardware specific driver, even less for
what specific hardware it is.
The same is true for the exported function name "mmci_init", the macro CONFIG_MMCI etc.
Then, in patch 2/3:
+int mmci_init(void)
but in patch 3/3:
+ rc = mmci_init(bis);
Seems you should add a prototype to include/mmc.h to detect such mistakes ;)
Best Regards,
Reinhard
next prev parent reply other threads:[~2011-02-25 3:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 2:35 [U-Boot] [PATCH 0/3] Add support for the MMC device to the vexpress matt.waddel at linaro.org
2011-02-25 2:35 ` [U-Boot] [PATCH 1/3] MMC: Max blocks value adjustable matt.waddel at linaro.org
2011-02-25 2:35 ` [U-Boot] [PATCH 2/3] MMC: Add support for PL180 ARM mmc device matt.waddel at linaro.org
2011-02-25 2:35 ` [U-Boot] [PATCH 3/3] ARMV7: Vexpress: Add MMC support matt.waddel at linaro.org
2011-02-25 3:02 ` Reinhard Meyer [this message]
2011-02-28 20:55 ` [U-Boot] [PATCH 0/3] Add support for the MMC device to the vexpress John Rigby
2011-03-01 0:05 ` [U-Boot] [PATCH V2 " matt.waddel at linaro.org
2011-03-01 5:58 ` Reinhard Meyer
2011-03-01 17:08 ` Matt Waddel
2011-03-01 20:28 ` Reinhard Meyer
2011-03-01 0:05 ` [U-Boot] [PATCH V2 2/3] MMC: Add support for PL180 ARM mmc device matt.waddel at linaro.org
2011-03-01 0:05 ` [U-Boot] [PATCH V2 3/3] ARMV7: Vexpress: Add MMC support matt.waddel at linaro.org
2011-03-03 5:22 ` [U-Boot] [PATCH V3 0/3] Add support for the MMC device to the vexpress matt.waddel at linaro.org
2011-03-03 5:22 ` [U-Boot] [PATCH v3 2/3] MMC: Add support for PL180 ARM mmc device matt.waddel at linaro.org
2011-04-13 11:04 ` Andy Fleming
2011-03-03 5:22 ` [U-Boot] [PATCH v3 3/3] ARMV7: Vexpress: Add MMC support matt.waddel at linaro.org
2011-04-13 11:09 ` Andy Fleming
2011-04-16 21:53 ` Matt Waddel
2011-04-28 18:46 ` John Rigby
2011-04-28 18:57 ` Andy Fleming
2011-04-28 19:49 ` John Rigby
2011-04-16 21:54 ` [U-Boot] [PATCH V4 0/3] Add support for the MMC device to the vexpress matt.waddel at linaro.org
2011-04-16 21:54 ` [U-Boot] [PATCH V4 1/3] MMC: Max blocks value adjustable matt.waddel at linaro.org
2011-04-16 21:54 ` [U-Boot] [PATCH V4 2/3] MMC: Add support for PL180 ARM mmc device matt.waddel at linaro.org
2011-04-16 21:54 ` [U-Boot] [PATCH V4 3/3] ARMV7: Vexpress: Add MMC support matt.waddel at linaro.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D671BCD.1090105@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox