From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiangfu Liu <xiangfu@openmobilefree.net>
Date: Mon, 28 Feb 2011 12:54:40 +0800
Subject: [U-Boot] [PATCH v5 1/8] those files are jz4740 base files
In-Reply-To: <20110117213500.DEA79D1CAD5@gemini.denx.de>
References: <1294589925-32639-1-git-send-email-xiangfu@openmobilefree.net>
	<1294589925-32639-2-git-send-email-xiangfu@openmobilefree.net>
	<20110117213500.DEA79D1CAD5@gemini.denx.de>
Message-ID: <4D6B2A90.3070706@openmobilefree.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Wolfgang Denk


On 01/18/2011 05:35 AM, Wolfgang Denk wrote:
> Please do not use base + offset notation.  Declare a proper C struct
> instead.  Please fix globally.
> 
>> > +	/* Disable port interrupts while changing hardware */
>> > +	*uart_ier = 0;
> And use proper I/O accessors to access device registers. Please fix
> globally.

I have delete all base + offset.  using C struct now. and using proper I/O accressors

> 
> ...
>> > +static ulong timestamp;
>> > +static ulong lastdec;
> As already has been pointed out several times before: this will not
> work because BSS cannot be accessed before relocation.
> 
> 

can you give me some tips how to fix this?

thanks

- -- 
Best Regards
Xiangfu Liu
http://www.openmobilefree.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1rKpAACgkQRRAEFRxkgLTsFwCbBXgBNGik7HRZpdqEaUGQWni4
F4oAnjCE/5HzHaTt8Rn1lSziHKhpGQyv
=ILT1
-----END PGP SIGNATURE-----