From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 14 Mar 2011 08:16:31 +0100 Subject: [U-Boot] [PATCH 01/20] keymile: rework headerfiles for keymile boards In-Reply-To: <20110313220004.704591518DB5@gemini.denx.de> References: <1299591018-8944-1-git-send-email-hs@denx.de> <1299591018-8944-2-git-send-email-hs@denx.de> <20110313220004.704591518DB5@gemini.denx.de> Message-ID: <4D7DC0CF.2040008@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, Wolfgang Denk wrote: > In message <1299591018-8944-2-git-send-email-hs@denx.de> you wrote: >> - This patch reworks all headerfiles for keymile boards (coge, supx4, >> eter1, suen3). >> Furthermore, a refactoring on the whole environment variables has been >> acomplished. > > Two independent changes => Please submit as two separate patches. Ok, I try to split this in two patches. > ... >> +#define CONFIG_HUSH_INIT_VAR 1 > ... >> +#define CONFIG_I2C_MULTI_BUS 1 > ... >> +#define CONFIG_I2C_MUX 1 > > Defines like these that select functions only should not be assigned > any numeric (or other value). Please omit thse. Please fix globally. Ok. >> +#define CONFIG_KM_DEF_ENV_CONSTANTS \ > ... >> + "default=" \ >> + "setenv default \'run newenv; reset\' && " \ > > These backslashes are redundant at best. Why not drop them? Ok, drop it. > ... >> + "u-boot=" xstr(CONFIG_HOSTNAME) "/u-boot.bin \0" \ > > Are you sure you really want that trailing blank? [Please check > globally.] Good cathc, check this. > ... >> +#define CONFIG_SYS_MONITOR_LEN (768 << 10) /* Reserve 768KB for Monitor */ > > Line too long. Please fix globally. Ok. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany