[U-Boot] [PATCH v3] Don't grab memory for LCD if FB address is defined

Wolfgang Denk
2011-04-24T23:27:55Z

Dear Minkyu Kang,

In message <4D8BE6BD.2090101@samsung.com> you wrote:
> If FB address is defined specific address then don't grab memory for LCD
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Albert Aribaud <albert.aribaud@free.fr>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Kim Phillips <kim.phillips@freescale.com>
> Cc: Andy Fleming <afleming@gmail.com>
> Cc: Kumar Gala <kumar.gala@freescale.com>
...
> --- /dev/null
> +++ b/doc/README.fb_addr
> @@ -0,0 +1,17 @@
> +Define CONFIG_FB_ADDR if you want to use specific address for frame buffer.
> +Then system will reserve the frame buffer address to defined address instead of
> +lcd_setmem (this function grab the memory for frame buffer by panel's size).
> +
> +Please see below code (in board_init_f function from arch/arm/lib/board.c)
> +
> +#ifdef CONFIG_FB_ADDR
> + gd->fb_base = CONFIG_FB_ADDR;
> +#else
> + /* reserve memory for LCD display (always full pages) */
> + addr = lcd_setmem (addr);
> + gd->fb_base = addr;
> +#endif /* CONFIG_FB_ADDR */
> +
> +If you want this config option then please define it at your board config file
> +
> +#define CONFIG_FB_ADDR 0x00000000

Sorry for the late review, but it makes littel sense to add individual
README.* files for each and every CONFIG option. Please add the
documentation (with a little less verbocity) to the top level README
instead.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When it is incorrect, it is, at least *authoritatively* incorrect.
- Hitchiker's Guide To The Galaxy