[U-Boot] [PATCH 1/3] ARM: Don't grab memory for LCD if FB address is defined

Wolfgang Denk
2011-03-13T19:50:21Z

Dear Minkyu Kang,

In message <4D75B591.3040605@samsung.com> you wrote:
> If FB address is defined specific address then don't grab memory for LCD
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Albert Aribaud <albert.aribaud@free.fr>
> ---
> arch/arm/lib/board.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index c620d2c..5a4d2bd 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag)
> #endif /* CONFIG_VFD */
>
> #ifdef CONFIG_LCD
> +#ifdef CONFIG_FB_ADDR

If you add a new CONFIG_ option, then you must document it (at least
in the README).

Also, you must not split this into several patches, one for each
architecture. All these changes must be done in a single commit.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A good marriage would be between a blind wife and deaf husband.
-- Michel de Montaigne