public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v2] powerpc: 'monitor' environment variable contains full video configuration
Date: Tue, 15 Mar 2011 10:21:16 -0500	[thread overview]
Message-ID: <4D7F83EC.4050804@freescale.com> (raw)
In-Reply-To: <20110315151544.AE7551518DB8@gemini.denx.de>

Wolfgang Denk wrote:
>> > because the kernel also needs to see "console=tty0" on the command line only if
> This may or may not be the case.  Frequently we still use a serial
> console even when booting with a graphics display enabled.
> 
> This is a different option, and does not belong into that setting.
> 
>> > video is supposed to be enabled.  I want to make video mode completely dynamic,
>> > so that if the 'video-mode' variable is set, then the console is switched to the
>> > video device, and the kernel is told to do the same.  Otherwise, all output will
>> > go to the serial port.

> NAK. video-mode settings and console settings are two separate things
> and must not be mangled into a single variable.

Well, that's why I have two variables.  My patch has the ability to set the
kernel command line appropriately if the video display is configured and enabled
in U-Boot.  The second variable is used to assist in setting the actual kernel
command-line, because that's the easiest and safest way to do it.  An
alternative that I tried to implement is to have do_bootm_linux() edit the
kernel command line directly, removing any existing video= option and putting a
new one in, but I found that to be too intrusive, especially since we don't have
any good string editing functions already in U-Boot.

There are three things that need to be done:

1) The video mode needs to be configured
2) The video display needs to be enabled and the U-Boot console needs to be
routed to it
3) The kernel command line needs to be set

For #1, we use video-mode.  How do you want #2 and #3 handled?

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2011-03-15 15:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14 20:19 [U-Boot] [PATCH] [v2] powerpc: 'monitor' environment variable contains full video configuration Timur Tabi
2011-03-14 23:33 ` Wolfgang Denk
2011-03-14 23:39   ` Tabi Timur-B04825
2011-03-15  9:05     ` Wolfgang Denk
2011-03-15 14:50       ` Timur Tabi
2011-03-15 15:15         ` Wolfgang Denk
2011-03-15 15:21           ` Timur Tabi [this message]
2011-03-15 15:47             ` Wolfgang Denk
2011-03-15 15:52               ` Timur Tabi
2011-03-15 19:02                 ` Wolfgang Denk
2011-03-15 19:09                   ` Timur Tabi
2011-03-15 19:38                     ` Wolfgang Denk
2011-03-15 19:49                       ` Timur Tabi
2011-03-15 20:41                         ` Wolfgang Denk
2011-03-15 20:48                           ` Timur Tabi
2011-03-15 21:47                             ` Wolfgang Denk
2011-03-15 22:32                               ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7F83EC.4050804@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox