[U-Boot] [PATCH] [v2] powerpc: 'monitor' environment variable contains full video configuration

Wolfgang Denk
2011-03-15T09:05:46Z

Dear Tabi Timur-B04825,

In message <4D7EA72C.9040603@freescale.com> you wrote:
>
> > Can this not be turned into generic code, usable for other boards /
> > systems as well?
>
> Possibly, but I would like to fix one bug at a time.

Agreed, but please not by introducing lots of new, probably later
incompatible code.

> > Please see the discussion we had about video modes for the i.MX
> > systems.
>
> Can you point me to the thread or at least tell me the subject line? I have
> no idea what you're talking about.

See http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/88169/focus=88240

> > I want to see handled most of this with generic code, not with
> > processor / architecture specific one.
>
> This patch also cleans up a lot of the DIU code to make it handle more gene-
> ric options.

OK, so please split that patch: one patch should do this cleanup, and
another one should contain the rest.

Instead of a non-standard and undocumented 'diubootargs' environment
variable please use something (probably called "video-mode" :-) that
can be passed as "video-mode=" boot argument to Linux.

At this point I wonder which use ther eis left for your "monitor"
variable - it should be completely redundant now?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Freudian slip is when you say one thing but mean your mother.