[U-Boot] [PATCH] [v2] powerpc: 'monitor' environment variable contains full video configuration

Timur Tabi
2011-03-15T14:50:33Z

Wolfgang Denk wrote:
> Agreed, but please not by introducing lots of new, probably later
> incompatible code.

Fair enough.

>> > Can you point me to the thread or at least tell me the subject line? I have
>> > no idea what you're talking about.

> See http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/88169/focus=88240

Ok, so what I get from that thread is to change the name of the variables
("monitor" -> "video" and "diubootargs" -> something else more generic) and
update the videomodes.c code to parse the same video string that the kernel
uses. I also gathered that no one has chosen to update videomodes.c, so I would
have to do it.

Do I have that right?

> OK, so please split that patch: one patch should do this cleanup, and
> another one should contain the rest.

I can't make any promises, since a lot of the code is intermingled.

> Instead of a non-standard and undocumented 'diubootargs' environment
> variable please use something (probably called "video-mode" :-) that
> can be passed as "video-mode=" boot argument to Linux.
>
> At this point I wonder which use ther eis left for your "monitor"
> variable - it should be completely redundant now?

Well, it may still be necessary to have two variables. One for the mode that
U-Boot parses, and one for the string that is passed to the kernel. This is
because the kernel also needs to see "console=tty0" on the command line only if
video is supposed to be enabled. I want to make video mode completely dynamic,
so that if the 'video-mode' variable is set, then the console is switched to the
video device, and the kernel is told to do the same. Otherwise, all output will
go to the serial port.

--
Timur Tabi
Linux kernel developer at Freescale

--
Timur Tabi
Linux kernel developer at Freescale