[U-Boot] [PATCH] [v2] powerpc: 'monitor' environment variable contains full video configuration

Wolfgang Denk
2011-03-15T15:15:44Z

Dear Timur Tabi,

In message <4D7F7CB9.8090005@freescale.com> you wrote:
>
> ("monitor" -> "video" and "diubootargs" -> something else more generic) and

video-mode ?

> update the videomodes.c code to parse the same video string that the kernel
> uses. I also gathered that no one has chosen to update videomodes.c, so I would
> have to do it.
>
> Do I have that right?

I think so.

Anatolij?
Stefano?

> > At this point I wonder which use ther eis left for your "monitor"
> > variable - it should be completely redundant now?
>
> Well, it may still be necessary to have two variables. One for the mode that

No, this is exactly what should be avoided.

> U-Boot parses, and one for the string that is passed to the kernel. This is

U-Boot and the Kernel should parse exactly the same variable.

> because the kernel also needs to see "console=tty0" on the command line only if

This may or may not be the case. Frequently we still use a serial
console even when booting with a graphics display enabled.

This is a different option, and does not belong into that setting.

> video is supposed to be enabled. I want to make video mode completely dynamic,
> so that if the 'video-mode' variable is set, then the console is switched to the
> video device, and the kernel is told to do the same. Otherwise, all output will
> go to the serial port.

NAK. video-mode settings and console settings are two separate things
and must not be mangled into a single variable.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
And now remains That we find out the cause of this effect, Or rather
say, the cause of this defect... -- Hamlet, Act II, Scene 2