[U-Boot] [PATCH v2 2/5] mvi2c: use structure to replace the direclty define

[Heiko Schocher <hs@denx.de>]

Hello Lei,

Lei Wen wrote:
> On Tue, Mar 15, 2011 at 2:54 PM, Heiko Schocher <hs@denx.de> wrote:
>> Hello Lei,
>>
>> Lei Wen wrote:
>>> Signed-off-by: Lei Wen <leiwen@marvell.com>
>>> ---
>>>  arch/arm/cpu/pxa/cpu.c                   |   11 +++
>>>  arch/arm/include/asm/arch-pxa/pxa-regs.h |   56 ------------
>>>  board/innokom/innokom.c                  |    9 +--
>>>  drivers/i2c/mvi2c.c                      |  139 +++++++++++++++++++++---------
>>>  include/configs/innokom.h                |    1 +
>>>  include/configs/xm250.h                  |    1 +
>>>  6 files changed, 111 insertions(+), 106 deletions(-)
>>>
[...]
>>> diff --git a/include/configs/innokom.h b/include/configs/innokom.h
>>> index 0ea73c9..1ddee03 100644
>>> --- a/include/configs/innokom.h
>>> +++ b/include/configs/innokom.h
>>> @@ -141,6 +141,7 @@
>>>   * I2C bus
>>>   */
>>>  #define CONFIG_I2C_MV                        1
>>> +#define CONFIG_PXA_I2C_REG           0x40301680
>> Hmm.. is there no define for this magic value?
>>
> 
> This value is for i2c base address. Do you mean it need a description?

There should be in a cpu specific header a define for it, which you
can use here.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany