public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rogan Dawes <rogan@dawes.za.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] orion5x: Fix wrong address in orion5x_sdram_bar
Date: Fri, 18 Mar 2011 07:57:33 +0200	[thread overview]
Message-ID: <4D82F44D.9040007@dawes.za.net> (raw)
In-Reply-To: <4D43C0AA.6050007@free.fr>

On 2011/01/29 9:24 AM, Albert ARIBAUD wrote:
> Hi Michael,
> 
> Le 29/01/2011 02:00, Michael Spang a ?crit :
>> This code intends to read the SDRAM controller base address registers
>> but is instead reading the CPU window base address registers.
> 
> Side note: IIUC this change is not required since the CPU Window 
> registers match the SDRAM controller registers on orion5x in U-boot; but 
> it is fine if only for the sake of correctness, and assuming it works 
> for other orion5x boards (testing underway for edminiv2).

I have this same change in my patch set for the DNS323, for what it is
worth. I must have needed it, but I can't remember exactly what the
behaviour was without it. :-)

Rogan

  parent reply	other threads:[~2011-03-18  5:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-29  1:00 [U-Boot] [PATCH 1/8] arm926ej-s: Invalidate instruction cache in flush_cache Michael Spang
2011-01-29  1:00 ` [U-Boot] [PATCH 2/8] orion5x: Fix wrong address in orion5x_sdram_bar Michael Spang
2011-01-29  7:24   ` Albert ARIBAUD
2011-03-17 19:47     ` Michael Spang
2011-03-18  5:57     ` Rogan Dawes [this message]
2011-03-18  6:46       ` Michael Spang
2011-01-29  1:00 ` [U-Boot] [PATCH 3/8] orion5x: Increase maximum bank size to 128M Michael Spang
2011-01-29  7:26   ` Albert ARIBAUD
2011-01-29  1:00 ` [U-Boot] [PATCH 4/8] orion5x: Allow SDRAM initialization to be omitted Michael Spang
2011-01-29  7:36   ` Albert ARIBAUD
2011-03-17 19:52     ` Michael Spang
2011-01-29  1:00 ` [U-Boot] [PATCH 5/8] mvgbe: Support preserving the existing MAC address Michael Spang
2011-01-29  1:00 ` [U-Boot] [PATCH 6/8] Add board support for TS-7800 Michael Spang
2011-01-29  7:39   ` Albert ARIBAUD
2011-03-17 19:50     ` Michael Spang
2011-01-30 19:14   ` Wolfgang Denk
2011-01-29  1:00 ` [U-Boot] [PATCH 7/8] Add NAND " Michael Spang
2011-01-30 19:15   ` Wolfgang Denk
2011-01-29  1:00 ` [U-Boot] [PATCH 8/8] Add README " Michael Spang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D82F44D.9040007@dawes.za.net \
    --to=rogan@dawes.za.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox