From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rogan Dawes Date: Fri, 18 Mar 2011 07:57:33 +0200 Subject: [U-Boot] [PATCH 2/8] orion5x: Fix wrong address in orion5x_sdram_bar In-Reply-To: <4D43C0AA.6050007@free.fr> References: <1296262841-8819-1-git-send-email-mspang@csclub.uwaterloo.ca> <1296262841-8819-2-git-send-email-mspang@csclub.uwaterloo.ca> <4D43C0AA.6050007@free.fr> Message-ID: <4D82F44D.9040007@dawes.za.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2011/01/29 9:24 AM, Albert ARIBAUD wrote: > Hi Michael, > > Le 29/01/2011 02:00, Michael Spang a ?crit : >> This code intends to read the SDRAM controller base address registers >> but is instead reading the CPU window base address registers. > > Side note: IIUC this change is not required since the CPU Window > registers match the SDRAM controller registers on orion5x in U-boot; but > it is fine if only for the sake of correctness, and assuming it works > for other orion5x boards (testing underway for edminiv2). I have this same change in my patch set for the DNS323, for what it is worth. I must have needed it, but I can't remember exactly what the behaviour was without it. :-) Rogan