From: Xiangfu Liu <xiangfu@openmobilefree.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 4/7] jz4740 nand driver
Date: Tue, 22 Mar 2011 16:11:03 +0800 [thread overview]
Message-ID: <4D885997.10607@openmobilefree.net> (raw)
In-Reply-To: <20110307174436.6b4c8b21@schlenkerla>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/08/2011 07:44 AM, Scott Wood wrote:
>> +#if defined(CONFIG_QI_LB60)
>> > +#define KEY_U_OUT (32 * 2 + 16)
>> > +#define KEY_U_IN (32 * 3 + 19)
>> > + __gpio_as_input(KEY_U_IN);
>> > + __gpio_enable_pull(KEY_U_IN);
>> > + __gpio_as_output(KEY_U_OUT);
>> > + __gpio_clear_pin(KEY_U_OUT);
>> > +
>> > + if (__gpio_get_pin(KEY_U_IN) == 0)
>> > + usb_boot();
>> > +#endif
>> > +#endif
> This stuff does not belong in the NAND driver; it belongs under your board
> or cpu directory.
>
I have tried to move those 'usb_boot' to board files. the only problem is
I have to run this 'usb_boot' very early. after CPU load the real u-boot to memory
the usb_boot will not working. I will try to found more info about this.
then explain more in next email.
thanks Scott Wood for your feedback.
I will keeping working. until the code is good enough :)
- --
Best Regards
Xiangfu Liu
http://www.openmobilefree.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk2IWZcACgkQRRAEFRxkgLTVvwCfaw7jKe7ZVzycMS+gN2lFdV2t
mEYAoIFahfXxtoiXs565cuN4vAuDdlIR
=tdrU
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-03-22 8:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 6:57 [U-Boot] [PATCH v6 0/7] those series patches for add ben nanonote board Xiangfu Liu
2011-02-28 6:57 ` [U-Boot] [PATCH v6 1/7] those files are jz4740 base files Xiangfu Liu
2011-02-28 6:57 ` [U-Boot] [PATCH v6 2/7] this is jz4740 head file Xiangfu Liu
2011-02-28 6:57 ` [U-Boot] [PATCH v6 3/7] jz4740 nand spl files Xiangfu Liu
2011-02-28 6:57 ` [U-Boot] [PATCH v6 4/7] jz4740 nand driver Xiangfu Liu
2011-02-28 6:57 ` [U-Boot] [PATCH v6 5/7] add Ben NanoNote board Xiangfu Liu
2011-02-28 6:57 ` [U-Boot] [PATCH v6 6/7] add entry to MAINTAINERS and boards.cfg Xiangfu Liu
2011-02-28 6:57 ` [U-Boot] [PATCH v6 7/7] modify files for ben nanonote board Xiangfu Liu
2011-03-15 3:16 ` Shinya Kuribayashi
2011-03-25 9:06 ` Xiangfu Liu
2011-03-07 23:44 ` [U-Boot] [PATCH v6 4/7] jz4740 nand driver Scott Wood
2011-03-22 8:11 ` Xiangfu Liu [this message]
2011-03-22 16:10 ` Scott Wood
2011-04-26 14:44 ` Xiangfu Liu
2011-03-25 9:17 ` Xiangfu Liu
2011-03-25 16:04 ` Scott Wood
2011-04-26 14:45 ` Xiangfu Liu
2011-03-15 2:27 ` [U-Boot] [PATCH v6 2/7] this is jz4740 head file Shinya Kuribayashi
2011-03-22 8:06 ` Xiangfu Liu
2011-03-15 2:26 ` [U-Boot] [PATCH v6 1/7] those files are jz4740 base files Shinya Kuribayashi
2011-03-22 8:06 ` Xiangfu Liu
2011-03-15 2:38 ` Shinya Kuribayashi
2011-03-22 8:05 ` Xiangfu Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D885997.10607@openmobilefree.net \
--to=xiangfu@openmobilefree.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox