[U-Boot] using env import to import textfiles

[U-Boot] using env import to import textfiles

[Holger Brunck]

Hi all,
we currently try to remove some of our default environment and add this
variables into textfiles which can be imported via
env import -t ${loadaddr} ${filesize}

One question to the textfiles. Should we add remarks to the environment
variables inside the textfile in C-Syntax (/* bla */), first test shows that the
import function works with this remarks . But whats the best way forward? Is
this way ok or should we add into the directory where this scripts reside an
additional README file where this variables are documented and remove the
comments from the textfiles?

Regards
Holger Brunck

[U-Boot] using env import to import textfiles

[Wolfgang Denk]

Dear Holger Brunck,

In message <4D91B854.3010905@keymile.com> you wrote:
>
> One question to the textfiles. Should we add remarks to the environment
> variables inside the textfile in C-Syntax (/* bla */), first test shows that the
> import function works with this remarks . But whats the best way forward? Is

This is not supposed to work as you think it does - these comments
will become part of the value of the respective environment variables.

At the moment, environment import does not support any kind of
comments, it's all raw data only.

This could be changed, of course, if needed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Minds are like parachutes - they only function when open.

[U-Boot] using env import to import textfiles

[Holger Brunck]

Hello,

Wolfgang Denk wrote:
> Dear Holger Brunck,
> 
> In message <4D91B854.3010905@keymile.com> you wrote:
>> One question to the textfiles. Should we add remarks to the environment
>> variables inside the textfile in C-Syntax (/* bla */), first test shows that the
>> import function works with this remarks . But whats the best way forward? Is
> 
> This is not supposed to work as you think it does - these comments
> will become part of the value of the respective environment variables.
> 

Ok.

> At the moment, environment import does not support any kind of
> comments, it's all raw data only.
> 
> This could be changed, of course, if needed.
> 

no and I don't think it is really needed. Importing only the environment and not
throwing afterwards unneeded parts from the textfile away seems to be more
efficient.

So we create an additional README file inside our scripts directory where this
variables are documented. Thanks.

Best regards
Holger Brunck