* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
@ 2011-03-29 19:42 Gray Remlin
2011-03-30 10:51 ` Albert ARIBAUD
2011-03-30 11:17 ` Prafulla Wadaskar
0 siblings, 2 replies; 8+ messages in thread
From: Gray Remlin @ 2011-03-29 19:42 UTC (permalink / raw)
To: u-boot
Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
Signed-off-by: Gray Remlin <gryrmln@gmail.com>
---
arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h
index 71ba464..f582ba4 100644
--- a/arch/arm/include/asm/arch-kirkwood/config.h
+++ b/arch/arm/include/asm/arch-kirkwood/config.h
@@ -128,7 +128,8 @@
#define CONFIG_LBA48
/* CONFIG_CMD_IDE requires some #defines for ATA registers */
#define CONFIG_SYS_IDE_MAXBUS 2
-#define CONFIG_SYS_IDE_MAXDEVICE 2
+/* Only one device per bus on SATA */
+#define CONFIG_SYS_IDE_MAXDEVICE 1
/* ATA registers base is at SATA controller base */
#define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
#endif /* CONFIG_CMD_IDE */
--
1.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
2011-03-29 19:42 [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus Gray Remlin
@ 2011-03-30 10:51 ` Albert ARIBAUD
2011-03-30 12:58 ` Gray Remlin
2011-03-30 11:17 ` Prafulla Wadaskar
1 sibling, 1 reply; 8+ messages in thread
From: Albert ARIBAUD @ 2011-03-30 10:51 UTC (permalink / raw)
To: u-boot
Hi Gray,
Le 29/03/2011 21:42, Gray Remlin a ?crit :
> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
>
> Signed-off-by: Gray Remlin<gryrmln@gmail.com>
> ---
> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h
> index 71ba464..f582ba4 100644
> --- a/arch/arm/include/asm/arch-kirkwood/config.h
> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
> @@ -128,7 +128,8 @@
> #define CONFIG_LBA48
> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
> #define CONFIG_SYS_IDE_MAXBUS 2
> -#define CONFIG_SYS_IDE_MAXDEVICE 2
> +/* Only one device per bus on SATA */
> +#define CONFIG_SYS_IDE_MAXDEVICE 1
> /* ATA registers base is at SATA controller base */
> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
> #endif /* CONFIG_CMD_IDE */
Did you cross-check this patch with Rogan's recent patch?
<http://patchwork.ozlabs.org/patch/87501/>
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
2011-03-30 10:51 ` Albert ARIBAUD
@ 2011-03-30 12:58 ` Gray Remlin
0 siblings, 0 replies; 8+ messages in thread
From: Gray Remlin @ 2011-03-30 12:58 UTC (permalink / raw)
To: u-boot
On 03/30/2011 11:51 AM, Albert ARIBAUD wrote:
> Hi Gray,
>
> Le 29/03/2011 21:42, Gray Remlin a ?crit :
>> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
>>
>> Signed-off-by: Gray Remlin<gryrmln@gmail.com>
>> ---
>> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h
>> index 71ba464..f582ba4 100644
>> --- a/arch/arm/include/asm/arch-kirkwood/config.h
>> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
>> @@ -128,7 +128,8 @@
>> #define CONFIG_LBA48
>> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
>> #define CONFIG_SYS_IDE_MAXBUS 2
>> -#define CONFIG_SYS_IDE_MAXDEVICE 2
>> +/* Only one device per bus on SATA */
>> +#define CONFIG_SYS_IDE_MAXDEVICE 1
>> /* ATA registers base is at SATA controller base */
>> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
>> #endif /* CONFIG_CMD_IDE */
> Did you cross-check this patch with Rogan's recent patch?
>
> <http://patchwork.ozlabs.org/patch/87501/>
>
> Amicalement,
No, this patch does not take Rogan's recent patch into consideration.
Rogan's patch does not address issues such as (from cmd_ide.c)
'array[CONFIG_SYS_IDE_MAXDEVICE]'
'for (i=0; i<CONFIG_SYS_IDE_MAXDEVICE; ++i)'
which will still be incorrect and will need to be patched up.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
2011-03-29 19:42 [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus Gray Remlin
2011-03-30 10:51 ` Albert ARIBAUD
@ 2011-03-30 11:17 ` Prafulla Wadaskar
1 sibling, 0 replies; 8+ messages in thread
From: Prafulla Wadaskar @ 2011-03-30 11:17 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Gray Remlin [mailto:gryrmln at gmail.com]
> Sent: Wednesday, March 30, 2011 1:12 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Gray Remlin
> Subject: [PATCH] Kirkwood: SATA supports only one device per bus
>
> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
Kirkwood supports max 2
Why do you want this change?
Regards..
Prafulla ..
>
> Signed-off-by: Gray Remlin <gryrmln@gmail.com>
> ---
> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
> b/arch/arm/include/asm/arch-kirkwood/config.h
> index 71ba464..f582ba4 100644
> --- a/arch/arm/include/asm/arch-kirkwood/config.h
> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
> @@ -128,7 +128,8 @@
> #define CONFIG_LBA48
> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
> #define CONFIG_SYS_IDE_MAXBUS 2
> -#define CONFIG_SYS_IDE_MAXDEVICE 2
> +/* Only one device per bus on SATA */
> +#define CONFIG_SYS_IDE_MAXDEVICE 1
> /* ATA registers base is at SATA controller base */
> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
> #endif /* CONFIG_CMD_IDE */
> --
> 1.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
@ 2011-03-30 11:21 Prafulla Wadaskar
2011-03-30 13:50 ` Gray Remlin
0 siblings, 1 reply; 8+ messages in thread
From: Prafulla Wadaskar @ 2011-03-30 11:21 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Prafulla Wadaskar
> Sent: Wednesday, March 30, 2011 4:48 PM
> To: 'Gray Remlin'
> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare
> Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
>
>
>
> > -----Original Message-----
> > From: Gray Remlin [mailto:gryrmln at gmail.com]
> > Sent: Wednesday, March 30, 2011 1:12 AM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; Gray Remlin
> > Subject: [PATCH] Kirkwood: SATA supports only one device per bus
> >
> > Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
>
> Kirkwood supports max 2
> Why do you want this change?
Hi Gray
I take back my words. I will study more and let you know my comments on this.
Sorry for noise.
Regards..
Prafulla . .
>
> Regards..
> Prafulla ..
>
> >
> > Signed-off-by: Gray Remlin <gryrmln@gmail.com>
> > ---
> > arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
> > b/arch/arm/include/asm/arch-kirkwood/config.h
> > index 71ba464..f582ba4 100644
> > --- a/arch/arm/include/asm/arch-kirkwood/config.h
> > +++ b/arch/arm/include/asm/arch-kirkwood/config.h
> > @@ -128,7 +128,8 @@
> > #define CONFIG_LBA48
> > /* CONFIG_CMD_IDE requires some #defines for ATA registers */
> > #define CONFIG_SYS_IDE_MAXBUS 2
> > -#define CONFIG_SYS_IDE_MAXDEVICE 2
> > +/* Only one device per bus on SATA */
> > +#define CONFIG_SYS_IDE_MAXDEVICE 1
> > /* ATA registers base is at SATA controller base */
> > #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
> > #endif /* CONFIG_CMD_IDE */
> > --
> > 1.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
2011-03-30 11:21 Prafulla Wadaskar
@ 2011-03-30 13:50 ` Gray Remlin
2011-03-30 18:59 ` Prafulla Wadaskar
0 siblings, 1 reply; 8+ messages in thread
From: Gray Remlin @ 2011-03-30 13:50 UTC (permalink / raw)
To: u-boot
On 03/30/2011 12:21 PM, Prafulla Wadaskar wrote:
>
>> -----Original Message-----
>> From: Prafulla Wadaskar
>> Sent: Wednesday, March 30, 2011 4:48 PM
>> To: 'Gray Remlin'
>> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare
>> Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
>>
>>
>>
>>> -----Original Message-----
>>> From: Gray Remlin [mailto:gryrmln at gmail.com]
>>> Sent: Wednesday, March 30, 2011 1:12 AM
>>> To: Prafulla Wadaskar
>>> Cc: u-boot at lists.denx.de; Gray Remlin
>>> Subject: [PATCH] Kirkwood: SATA supports only one device per bus
>>>
>>> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
>> Kirkwood supports max 2
>> Why do you want this change?
> Hi Gray
> I take back my words. I will study more and let you know my comments on this.
> Sorry for noise.
>
> Regards..
> Prafulla . .
>
>> Regards..
>> Prafulla ..
>>
>>> Signed-off-by: Gray Remlin<gryrmln@gmail.com>
>>> ---
>>> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
>>> b/arch/arm/include/asm/arch-kirkwood/config.h
>>> index 71ba464..f582ba4 100644
>>> --- a/arch/arm/include/asm/arch-kirkwood/config.h
>>> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
>>> @@ -128,7 +128,8 @@
>>> #define CONFIG_LBA48
>>> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
>>> #define CONFIG_SYS_IDE_MAXBUS 2
>>> -#define CONFIG_SYS_IDE_MAXDEVICE 2
>>> +/* Only one device per bus on SATA */
>>> +#define CONFIG_SYS_IDE_MAXDEVICE 1
>>> /* ATA registers base is at SATA controller base */
>>> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
>>> #endif /* CONFIG_CMD_IDE */
>>> --
>>> 1.7.4
Hi Prafulla,
This one was a bit of a judgement call.
You are absolutely correct in what you say that Kirkwood supports two, but
to the best of my knowledge, no one has yet implemented a board using
both busses (I am not that familiar with OpenRD, I may have to eat my
words).
For the sheevaplug, guruplug & dreamplug, it is definitely the case that
only
one device can be attached.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
2011-03-30 13:50 ` Gray Remlin
@ 2011-03-30 18:59 ` Prafulla Wadaskar
2011-03-30 19:51 ` Albert ARIBAUD
0 siblings, 1 reply; 8+ messages in thread
From: Prafulla Wadaskar @ 2011-03-30 18:59 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Gray Remlin [mailto:gryrmln at gmail.com]
> Sent: Wednesday, March 30, 2011 7:21 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de
> Subject: Re: [PATCH] Kirkwood: SATA supports only one device per bus
>
> On 03/30/2011 12:21 PM, Prafulla Wadaskar wrote:
> >
> >> -----Original Message-----
> >> From: Prafulla Wadaskar
> >> Sent: Wednesday, March 30, 2011 4:48 PM
> >> To: 'Gray Remlin'
> >> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare
> >> Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
> >>
> >>
> >>
> >>> -----Original Message-----
> >>> From: Gray Remlin [mailto:gryrmln at gmail.com]
> >>> Sent: Wednesday, March 30, 2011 1:12 AM
> >>> To: Prafulla Wadaskar
> >>> Cc: u-boot at lists.denx.de; Gray Remlin
> >>> Subject: [PATCH] Kirkwood: SATA supports only one device per bus
> >>>
> >>> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
> >> Kirkwood supports max 2
> >> Why do you want this change?
> > Hi Gray
> > I take back my words. I will study more and let you know my comments
> on this.
> > Sorry for noise.
> >
> > Regards..
> > Prafulla . .
> >
> >> Regards..
> >> Prafulla ..
> >>
> >>> Signed-off-by: Gray Remlin<gryrmln@gmail.com>
> >>> ---
> >>> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
> >>> 1 files changed, 2 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
> >>> b/arch/arm/include/asm/arch-kirkwood/config.h
> >>> index 71ba464..f582ba4 100644
> >>> --- a/arch/arm/include/asm/arch-kirkwood/config.h
> >>> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
> >>> @@ -128,7 +128,8 @@
> >>> #define CONFIG_LBA48
> >>> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
> >>> #define CONFIG_SYS_IDE_MAXBUS 2
> >>> -#define CONFIG_SYS_IDE_MAXDEVICE 2
> >>> +/* Only one device per bus on SATA */
> >>> +#define CONFIG_SYS_IDE_MAXDEVICE 1
> >>> /* ATA registers base is at SATA controller base */
> >>> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
> >>> #endif /* CONFIG_CMD_IDE */
> >>> --
> >>> 1.7.4
> Hi Prafulla,
>
> This one was a bit of a judgement call.
> You are absolutely correct in what you say that Kirkwood supports two,
> but
> to the best of my knowledge, no one has yet implemented a board using
> both busses (I am not that familiar with OpenRD, I may have to eat my
> words).
OpenRD-Base board has two, one e-sata for external hdd and one sata for onboard hdd interface, I am using them :-)
Regards..
Prafulla . .
>
> For the sheevaplug, guruplug & dreamplug, it is definitely the case that
> only
> one device can be attached.
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
2011-03-30 18:59 ` Prafulla Wadaskar
@ 2011-03-30 19:51 ` Albert ARIBAUD
0 siblings, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2011-03-30 19:51 UTC (permalink / raw)
To: u-boot
Le 30/03/2011 20:59, Prafulla Wadaskar a ?crit :
>> to the best of my knowledge, no one has yet implemented a board using
>> both busses (I am not that familiar with OpenRD, I may have to eat my
>> words).
>
> OpenRD-Base board has two, one e-sata for external hdd and one sata for onboard hdd interface, I am using them :-)
In which case it makes sense to keep CONFIG_SYS_IDE_MAXDEVICE set to 2
in the common code and redefine it to 1 in board configs that only
implement one, does it not?
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-03-30 19:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-29 19:42 [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus Gray Remlin
2011-03-30 10:51 ` Albert ARIBAUD
2011-03-30 12:58 ` Gray Remlin
2011-03-30 11:17 ` Prafulla Wadaskar
-- strict thread matches above, loose matches on Subject: below --
2011-03-30 11:21 Prafulla Wadaskar
2011-03-30 13:50 ` Gray Remlin
2011-03-30 18:59 ` Prafulla Wadaskar
2011-03-30 19:51 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox