From: Gray Remlin <gryrmln@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
Date: Wed, 30 Mar 2011 14:50:53 +0100 [thread overview]
Message-ID: <4D93353D.7020509@gmail.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19F981B7AB@SC-VEXCH4.marvell.com>
On 03/30/2011 12:21 PM, Prafulla Wadaskar wrote:
>
>> -----Original Message-----
>> From: Prafulla Wadaskar
>> Sent: Wednesday, March 30, 2011 4:48 PM
>> To: 'Gray Remlin'
>> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare
>> Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
>>
>>
>>
>>> -----Original Message-----
>>> From: Gray Remlin [mailto:gryrmln at gmail.com]
>>> Sent: Wednesday, March 30, 2011 1:12 AM
>>> To: Prafulla Wadaskar
>>> Cc: u-boot at lists.denx.de; Gray Remlin
>>> Subject: [PATCH] Kirkwood: SATA supports only one device per bus
>>>
>>> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
>> Kirkwood supports max 2
>> Why do you want this change?
> Hi Gray
> I take back my words. I will study more and let you know my comments on this.
> Sorry for noise.
>
> Regards..
> Prafulla . .
>
>> Regards..
>> Prafulla ..
>>
>>> Signed-off-by: Gray Remlin<gryrmln@gmail.com>
>>> ---
>>> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
>>> b/arch/arm/include/asm/arch-kirkwood/config.h
>>> index 71ba464..f582ba4 100644
>>> --- a/arch/arm/include/asm/arch-kirkwood/config.h
>>> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
>>> @@ -128,7 +128,8 @@
>>> #define CONFIG_LBA48
>>> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
>>> #define CONFIG_SYS_IDE_MAXBUS 2
>>> -#define CONFIG_SYS_IDE_MAXDEVICE 2
>>> +/* Only one device per bus on SATA */
>>> +#define CONFIG_SYS_IDE_MAXDEVICE 1
>>> /* ATA registers base is at SATA controller base */
>>> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
>>> #endif /* CONFIG_CMD_IDE */
>>> --
>>> 1.7.4
Hi Prafulla,
This one was a bit of a judgement call.
You are absolutely correct in what you say that Kirkwood supports two, but
to the best of my knowledge, no one has yet implemented a board using
both busses (I am not that familiar with OpenRD, I may have to eat my
words).
For the sheevaplug, guruplug & dreamplug, it is definitely the case that
only
one device can be attached.
next prev parent reply other threads:[~2011-03-30 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 11:21 [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus Prafulla Wadaskar
2011-03-30 13:50 ` Gray Remlin [this message]
2011-03-30 18:59 ` Prafulla Wadaskar
2011-03-30 19:51 ` Albert ARIBAUD
-- strict thread matches above, loose matches on Subject: below --
2011-03-29 19:42 Gray Remlin
2011-03-30 10:51 ` Albert ARIBAUD
2011-03-30 12:58 ` Gray Remlin
2011-03-30 11:17 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D93353D.7020509@gmail.com \
--to=gryrmln@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox