[U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus

Gray Remlin
2011-03-30T13:50:53Z

On 03/30/2011 12:21 PM, Prafulla Wadaskar wrote:
>
>> -----Original Message-----
>> From: Prafulla Wadaskar
>> Sent: Wednesday, March 30, 2011 4:48 PM
>> To: 'Gray Remlin'
>> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare
>> Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
>>
>>
>>
>>> -----Original Message-----
>>> From: Gray Remlin [mailto:gryrmln at gmail.com]
>>> Sent: Wednesday, March 30, 2011 1:12 AM
>>> To: Prafulla Wadaskar
>>> Cc: u-boot at lists.denx.de; Gray Remlin
>>> Subject: [PATCH] Kirkwood: SATA supports only one device per bus
>>>
>>> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
>> Kirkwood supports max 2
>> Why do you want this change?
> Hi Gray
> I take back my words. I will study more and let you know my comments on this.
> Sorry for noise.
>
> Regards..
> Prafulla . .
>
>> Regards..
>> Prafulla ..
>>
>>> Signed-off-by: Gray Remlin<gryrmln@gmail.com>
>>> ---
>>> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
>>> b/arch/arm/include/asm/arch-kirkwood/config.h
>>> index 71ba464..f582ba4 100644
>>> --- a/arch/arm/include/asm/arch-kirkwood/config.h
>>> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
>>> @@ -128,7 +128,8 @@
>>> #define CONFIG_LBA48
>>> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
>>> #define CONFIG_SYS_IDE_MAXBUS 2
>>> -#define CONFIG_SYS_IDE_MAXDEVICE 2
>>> +/* Only one device per bus on SATA */
>>> +#define CONFIG_SYS_IDE_MAXDEVICE 1
>>> /* ATA registers base is at SATA controller base */
>>> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
>>> #endif /* CONFIG_CMD_IDE */
>>> --
>>> 1.7.4
Hi Prafulla,

This one was a bit of a judgement call.
You are absolutely correct in what you say that Kirkwood supports two, but
to the best of my knowledge, no one has yet implemented a board using
both busses (I am not that familiar with OpenRD, I may have to eat my
words).

For the sheevaplug, guruplug & dreamplug, it is definitely the case that
only
one device can be attached.