[U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus

Gray Remlin
2011-03-30T12:58:38Z

On 03/30/2011 11:51 AM, Albert ARIBAUD wrote:
> Hi Gray,
>
> Le 29/03/2011 21:42, Gray Remlin a ?crit :
>> Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
>>
>> Signed-off-by: Gray Remlin<gryrmln@gmail.com>
>> ---
>> arch/arm/include/asm/arch-kirkwood/config.h | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h
>> index 71ba464..f582ba4 100644
>> --- a/arch/arm/include/asm/arch-kirkwood/config.h
>> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
>> @@ -128,7 +128,8 @@
>> #define CONFIG_LBA48
>> /* CONFIG_CMD_IDE requires some #defines for ATA registers */
>> #define CONFIG_SYS_IDE_MAXBUS 2
>> -#define CONFIG_SYS_IDE_MAXDEVICE 2
>> +/* Only one device per bus on SATA */
>> +#define CONFIG_SYS_IDE_MAXDEVICE 1
>> /* ATA registers base is at SATA controller base */
>> #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
>> #endif /* CONFIG_CMD_IDE */
> Did you cross-check this patch with Rogan's recent patch?
>
> <http://patchwork.ozlabs.org/patch/87501/>
>
> Amicalement,
No, this patch does not take Rogan's recent patch into consideration.

Rogan's patch does not address issues such as (from cmd_ide.c)

'array[CONFIG_SYS_IDE_MAXDEVICE]'

'for (i=0; i<CONFIG_SYS_IDE_MAXDEVICE; ++i)'

which will still be incorrect and will need to be patched up.