From: Alexander Holler <holler@ahsoftware.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Provide pr_debug() and pr_info().
Date: Fri, 01 Apr 2011 21:40:55 +0200 [thread overview]
Message-ID: <4D962A47.9000503@ahsoftware.de> (raw)
In-Reply-To: <20110401175611.0CBD5F0320D@gemini.denx.de>
Hello,
Am 01.04.2011 19:56, schrieb Wolfgang Denk:
> Dear Alexander Holler,
>
> In message<1301674331-7476-1-git-send-email-holler@ahsoftware.de> you wrote:
>> Those are usefull for compatibility with the kernel.
>> Remove the locally defined pr_debug() in atmel_mci.c.
>>
>> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>> ---
>> drivers/mmc/atmel_mci.c | 6 ------
>> include/common.h | 4 ++++
>> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> NAK. This is just adding redundant overhead. I don;t want to have
> yet another incarnation of macros which already exist.
>
> Either replace the code in drivers/mmc/atmel_mci.c by a simple
>
> #define pr_debug(fmt, args...) debug(fmt, ##args)
>
> or convert the code that uses this reference.
>
> And pr_info() is completrely redundant and not used anywhere.
>
>
> If you really think that pr_debug() is so much better than debug(),
> then convert ALL code to use that. But I am not a friend of such a
> change.
Than just forget this patch and someone else should add those macros to
future imports of sources from the kernel. At least I will now do so.
Regards,
Alexander Holler
prev parent reply other threads:[~2011-04-01 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 16:12 [U-Boot] [PATCH] Provide pr_debug() and pr_info() Alexander Holler
2011-04-01 17:56 ` Wolfgang Denk
2011-04-01 19:40 ` Alexander Holler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D962A47.9000503@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox