From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [0/6] Patch serie UBI min I/O size fixes
Date: Mon, 04 Apr 2011 13:15:09 +0200 [thread overview]
Message-ID: <4D99A83D.9040008@keymile.com> (raw)
In-Reply-To: <201104041251.58335.sr@denx.de>
Hi Stefan,
Stefan Roese wrote:
> Hi Holger,
>
> On Thursday 20 January 2011 17:16:32 Holger Brunck wrote:
>> This patch serie fixes a problem in the UBI layer. The min I/O size has
>> currently a fixed value of 1 for NOR flashes. But for NOR flashes the min
>> I/O size has to be equal to the size of the writebuffer of the flash.
>> Therefore the mtd layer was enhanced with the writebuffer which was later
>> on used in the ubi layer to set the min I/O size.
>>
>> This patches fixes problems with flash types with a writebuffersize > 128
>> Byte and is mainly taken from the similar linux patches. See MTD mailing
>> list posts:
>> http://lists.infradead.org/pipermail/linux-mtd/2010-December/033460.html
>>
>> Without the u-boot patches attaching to a ubi device with a min I/O buffer
>> larger than 128 would fail.
>
> IIRC (please correct me if I'm wrong), the Linux part of these patches has
> undergone some changes. Is this U-Boot patch series still up-to-date?
>
no. The assumption that (mtd->writebufsize == min I/O size in UBI) for NOR
flashes was incorrect and the patch UBI: use mtd->writebufsize to set minimal
I/O unit size was reverted in the mainline kernel. Whats still part in the
kernel is the enhancement of the mtd struct with the writebufsize. But also in
this topic some changes are made. So the patch series should be dropped or
updated with the recent changes.
But currently due to the changes I did not see a usage for this additional value
for u-boot. For this reason I propose to drop the patch series.
Best regards
Holger
next prev parent reply other threads:[~2011-04-04 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 16:16 [U-Boot] [0/6] Patch serie UBI min I/O size fixes Holger Brunck
2011-04-04 10:51 ` Stefan Roese
2011-04-04 11:15 ` Holger Brunck [this message]
[not found] <4D41331C.7000302@keymile.com>
2011-01-27 12:13 ` Holger Brunck
2011-01-27 16:52 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D99A83D.9040008@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox