From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Thompson <nick.thompson@ge.com>
Date: Tue, 05 Apr 2011 17:07:13 +0100
Subject: [U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env
In-Reply-To: <BANLkTikCmim+x_tdLN0XOhLBzHcBBuUCjA@mail.gmail.com>
References: <4D9B2233.5060506@ge.com>
	<BANLkTikCmim+x_tdLN0XOhLBzHcBBuUCjA@mail.gmail.com>
Message-ID: <4D9B3E31.6080304@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/04/11 16:52, Mike Frysinger wrote:
> On Tue, Apr 5, 2011 at 10:07 AM, Nick Thompson wrote:
>> common/console.c has this function:
>>
>> /* Called before relocation - use serial functions */
>> int console_init_f(void)
>> {
>>        gd->have_console = 1;
>>
>> #ifdef CONFIG_SILENT_CONSOLE
>>        if (getenv("silent") != NULL)
>>                gd->flags |= GD_FLG_SILENT;
>> #endif
>>
>>        return 0;
>> }
>>
>> I have defined CONFIG_SILENT_CONSOLE and set "silent" in my NAND env,
>> but the SILENT flag doesn't get set.
>>
>> I suspect this function is called way too early for NAND env to be available.
> NAND isnt the only one with this problem (SPI does too last i looked).
>  during early boot, you only have the default env available.  so if
> you want silent console, i'd suggest you enable that in your default
> env.
> -mike

Yes, that's what I intend to do, I think, though I'd have liked it to be
configurable at run time.

Thanks for the info,
Nick.