[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[Nick Thompson]

common/console.c has this function:

/* Called before relocation - use serial functions */
int console_init_f(void)
{
        gd->have_console = 1;

#ifdef CONFIG_SILENT_CONSOLE
        if (getenv("silent") != NULL)
                gd->flags |= GD_FLG_SILENT;
#endif

        return 0;
}

I have defined CONFIG_SILENT_CONSOLE and set "silent" in my NAND env,
but the SILENT flag doesn't get set.

I suspect this function is called way too early for NAND env to be available.

I can set the flag unconditionally and that works fine, but I don't think that
that will make a patch worthy of submission...?

Any thoughts?

Thanks,
Nick.

[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[Mike Frysinger]

On Tue, Apr 5, 2011 at 10:07 AM, Nick Thompson wrote:
> common/console.c has this function:
>
> /* Called before relocation - use serial functions */
> int console_init_f(void)
> {
> ? ? ? ?gd->have_console = 1;
>
> #ifdef CONFIG_SILENT_CONSOLE
> ? ? ? ?if (getenv("silent") != NULL)
> ? ? ? ? ? ? ? ?gd->flags |= GD_FLG_SILENT;
> #endif
>
> ? ? ? ?return 0;
> }
>
> I have defined CONFIG_SILENT_CONSOLE and set "silent" in my NAND env,
> but the SILENT flag doesn't get set.
>
> I suspect this function is called way too early for NAND env to be available.

NAND isnt the only one with this problem (SPI does too last i looked).
 during early boot, you only have the default env available.  so if
you want silent console, i'd suggest you enable that in your default
env.
-mike

[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[Nick Thompson]

On 05/04/11 16:52, Mike Frysinger wrote:
> On Tue, Apr 5, 2011 at 10:07 AM, Nick Thompson wrote:
>> common/console.c has this function:
>>
>> /* Called before relocation - use serial functions */
>> int console_init_f(void)
>> {
>>        gd->have_console = 1;
>>
>> #ifdef CONFIG_SILENT_CONSOLE
>>        if (getenv("silent") != NULL)
>>                gd->flags |= GD_FLG_SILENT;
>> #endif
>>
>>        return 0;
>> }
>>
>> I have defined CONFIG_SILENT_CONSOLE and set "silent" in my NAND env,
>> but the SILENT flag doesn't get set.
>>
>> I suspect this function is called way too early for NAND env to be available.
> NAND isnt the only one with this problem (SPI does too last i looked).
>  during early boot, you only have the default env available.  so if
> you want silent console, i'd suggest you enable that in your default
> env.
> -mike

Yes, that's what I intend to do, I think, though I'd have liked it to be
configurable at run time.

Thanks for the info,
Nick.

[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[Scott Wood]

On Tue, 5 Apr 2011 17:07:13 +0100
Nick Thompson <nick.thompson@ge.com> wrote:

> On 05/04/11 16:52, Mike Frysinger wrote:
> > On Tue, Apr 5, 2011 at 10:07 AM, Nick Thompson wrote:
> >> common/console.c has this function:
> >>
> >> /* Called before relocation - use serial functions */
> >> int console_init_f(void)
> >> {
> >>        gd->have_console = 1;
> >>
> >> #ifdef CONFIG_SILENT_CONSOLE
> >>        if (getenv("silent") != NULL)
> >>                gd->flags |= GD_FLG_SILENT;
> >> #endif
> >>
> >>        return 0;
> >> }
> >>
> >> I have defined CONFIG_SILENT_CONSOLE and set "silent" in my NAND env,
> >> but the SILENT flag doesn't get set.
> >>
> >> I suspect this function is called way too early for NAND env to be available.
> > NAND isnt the only one with this problem (SPI does too last i looked).
> >  during early boot, you only have the default env available.  so if
> > you want silent console, i'd suggest you enable that in your default
> > env.
> > -mike
> 
> Yes, that's what I intend to do, I think, though I'd have liked it to be
> configurable at run time.

Try enabling CONFIG_NAND_ENV_DST to have the environment be loaded by the
SPL along with the main U-Boot image.  You didn't say what board/chip
you're using, so if you're using something other than the common
nand_boot.c you may need to add support for this (it's just a couple
lines), and silence any output from the SPL itself.

-Scott

[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[Nick Thompson]

On 05/04/11 18:46, Scott Wood wrote:
> On Tue, 5 Apr 2011 17:07:13 +0100
> Nick Thompson <nick.thompson@ge.com> wrote:
>
>> On 05/04/11 16:52, Mike Frysinger wrote:
>>> On Tue, Apr 5, 2011 at 10:07 AM, Nick Thompson wrote:
>>>> common/console.c has this function:
>>>>
>>>> /* Called before relocation - use serial functions */
>>>> int console_init_f(void)
>>>> {
>>>>        gd->have_console = 1;
>>>>
>>>> #ifdef CONFIG_SILENT_CONSOLE
>>>>        if (getenv("silent") != NULL)
>>>>                gd->flags |= GD_FLG_SILENT;
>>>> #endif
>>>>
>>>>        return 0;
>>>> }
>>>>
>>>> I have defined CONFIG_SILENT_CONSOLE and set "silent" in my NAND env,
>>>> but the SILENT flag doesn't get set.
>>>>
>>>> I suspect this function is called way too early for NAND env to be available.
>>> NAND isnt the only one with this problem (SPI does too last i looked).
>>>  during early boot, you only have the default env available.  so if
>>> you want silent console, i'd suggest you enable that in your default
>>> env.
>>> -mike
>> Yes, that's what I intend to do, I think, though I'd have liked it to be
>> configurable at run time.
> Try enabling CONFIG_NAND_ENV_DST to have the environment be loaded by the
> SPL along with the main U-Boot image.  You didn't say what board/chip
> you're using, so if you're using something other than the common
> nand_boot.c you may need to add support for this (it's just a couple
> lines), and silence any output from the SPL itself.
>
> -Scott
>
Thanks Scott,

That's interesting. I'm using a TI board (da830evm). Unfortunately it has its
own UBL, so I don't have the SPL to configure that way.

That might be a good reason to consider dropping the UBL though. I believe
TI are moving to U-Boot SPL themselves.

I'll add it to my TODO list.

Thanks,
Nick.

[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[Wolfgang Denk]

Dear Nick Thompson,

In message <4D9C2274.3080602@ge.com> you wrote:
>
> That's interesting. I'm using a TI board (da830evm). Unfortunately it has its
> own UBL, so I don't have the SPL to configure that way.

There is little reason to stick with UBL.  You can get rid of it and
use the SPL approach instead - this is no real technical challenge,
but just a "little effort".

> That might be a good reason to consider dropping the UBL though. I believe
> TI are moving to U-Boot SPL themselves.

Are they?  Do you have any pointers?

> I'll add it to my TODO list.

Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Keep your head and your heart going in the right  direction  and  you
will not have to worry about your feet.

[U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env

[Nick Thompson]

On 06/04/11 10:22, Wolfgang Denk wrote:
> Dear Nick Thompson,
>
> In message <4D9C2274.3080602@ge.com> you wrote:
>> That might be a good reason to consider dropping the UBL though. I believe
>> TI are moving to U-Boot SPL themselves.
> Are they?  Do you have any pointers?

There have been some SPL submissions from TI people, for example:

http://www.mail-archive.com/u-boot at lists.denx.de/msg48557.html

I believe the work is focused on OMAP4, with OMAP3 as a later addition.

I notice there is already something in repo for da8xx, though not from
TI. I think I need to take a look at that.

Nick.