From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Handle most LDSCRIPT setting centrally
Date: Fri, 08 Apr 2011 16:07:40 +1000 [thread overview]
Message-ID: <4D9EA62C.8000101@gmail.com> (raw)
In-Reply-To: <20110407110146.1fd1333d@schlenkerla.am.freescale.net>
On 08/04/11 02:01, Scott Wood wrote:
> On Thu, 7 Apr 2011 09:11:03 +0200
> Wolfgang Denk <wd@denx.de> wrote:
>
>> Dear Scott Wood,
>>
>> In message <20110406233136.GA13709@schlenkerla.am.freescale.net> you wrote:
>>> Currently, some linker scripts are found by common code in config.mk.
>>> Some are found using CONFIG_SYS_LDSCRIPT, but the code for that is
>>> sometimes in arch config.mk and sometimes in board config.mk. Some
>>> are found using an arch-specific rule for looking in CPUDIR, etc.
>>>
>>> Further, the powerpc config.mk rule relied on CONFIG_NAND_SPL
>>> when it really wanted CONFIG_NAND_U_BOOT -- which covered up the fact
>>> that not all NAND_U_BOOT builds actually wanted CPUDIR/u-boot-nand.lds.
>>>
>>> Replace all of this -- except for a handful of boards that are actually
>>> selecting a linker script in a unique way -- with centralized ldscript
>>> finding.
>>
>> Thanks for this nice cleanup.
>>
>> Only one question: Which boards / architectures did you cover during
>> your tests?
>
> As I noted, I did a MAKEALL ppc and all the output (sizes, errors, etc) was
> the same as before the patch.
>
> I tried a few arm boards, and all the ones I tried failed the same way they
> did before the patch. I don't have toolchains for the other arches
> readily available. Any help in testing this change on non-ppc would be
> appreciated.
>
I have tried this patch on all (two!) x86 configurations and looks good
You may have my:
Tested-by: Graeme Russ <graeme.russ@gmail.com>
Regards,
Graeme
next prev parent reply other threads:[~2011-04-08 6:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 23:31 [U-Boot] [PATCH] Handle most LDSCRIPT setting centrally Scott Wood
2011-04-07 7:11 ` Wolfgang Denk
2011-04-07 16:01 ` Scott Wood
2011-04-08 6:07 ` Graeme Russ [this message]
2011-04-07 19:55 ` Mike Frysinger
2011-04-08 4:56 ` [U-Boot] [PATCH] Blackfin: use common LDSCRIPT logic Mike Frysinger
2011-04-08 5:29 ` Mike Frysinger
2011-04-29 23:00 ` [U-Boot] [PATCH] Handle most LDSCRIPT setting centrally Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9EA62C.8000101@gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox