From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Schwarz <andre.schwarz@matrix-vision.de>
Date: Fri, 08 Apr 2011 18:43:32 +0200
Subject: [U-Boot] [RFC] mpc83xx: add config options to spd_sdram
In-Reply-To: <1302280570.7417.8.camel@oslab-l1>
References: <4D9AE5BD.704@matrix-vision.de>	
	<20110405165227.78ecd5bd.kim.phillips@freescale.com>	
	<4D9C21EA.3070005@matrix-vision.de>
	<1302107849.4586.14.camel@oslab-l1>	
	<908840060.379.1302115339879.JavaMail.open-xchange@proteus>	
	<1427125824.654.1302208977309.JavaMail.open-xchange@proteus>	
	<1302209771.19969.7.camel@oslab-l1>
	<4D9EBC3F.6040203@matrix-vision.de>	
	<1302276715.7417.5.camel@oslab-l1>
	<4D9F37EA.8030004@matrix-vision.de>
	<1302280570.7417.8.camel@oslab-l1>
Message-ID: <4D9F3B34.7080703@matrix-vision.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/08/2011 06:36 PM, York Sun wrote:
> On Fri, 2011-04-08 at 18:29 +0200, Andre Schwarz wrote:
>> York,
>>> On Fri, 2011-04-08 at 09:41 +0200, Andre Schwarz wrote:
>>>>> I am sorry I totally ignored the subject with mpc83xx. I was thinking of
>>>>> mpc85xx.
>>>> ok - no "new" code for 83xx then.
>>>>> You are right the old code is in spd_sdram.c and it is still in use for
>>>>> mpc83xx. Unless to adjust the code, there is no board specific file.
>>>>>
>>>> Are you willing to accept some changes to spd_sdram.c or will I have
>>>> another out-of-tree board  ?
>>>>
>>>> What we need is :
>>>>
>>>> - more configurable settings like driver strength, cpo and odt values.
>>>> - Reading SPD data from an arbitrary i2c eeprom.
>>>>
>>>> What's so bad about my proposal ?
>>>> Please let me know so that I'm able to improve.
>>>>
>>> I welcome the change to use the new code since the feature you asked is
>>> already there.
>> sorry, but I'm not sure if I understand this correctly.
>>
>> What I need is some minor non-intrusive changes to 83xx-specific file
>> spd_sdram.c because it is the most straightforward solution with *no*
>> impact on code size or other existing boards. So: The feature I ask for
>> is *not* already there.
>>
>> What I definitely won't do is use the "new" fsl ddr code in mpc8xxx/ddr
>> because it completely lacks 83xx support.
>> So: The feature I ask for is there but my CPU family is not supported.
>> IMHO the "new" code is total overkill for 83xx.
>>
> It would be easier to maintain one set of code. But if the change you
> need is relatively small to the old code and doesn't have negative
> impact on other boards, go ahead to post the patch.
yes - that's what I've been asking for.
So far Kim's NAK is still valid - let's see what his favorite solution 
will look like.

Thank you for sharing your thoughts.


Regards,
Andr?

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner