[U-Boot] [PATCH] arm/km: add mkimage config file for uart download

[U-Boot] [PATCH] arm/km: add mkimage config file for uart download

[Prafulla Wadaskar]

> -----Original Message-----
> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
> Sent: Friday, April 08, 2011 6:18 PM
> To: u-boot at lists.denx.de
> Cc: holger.brunck at keymile.com; hs at denx.de; Valentin Longchamp; Wolfgang
> Denk; Detlev Zundel; Prafulla Wadaskar
> Subject: [PATCH] arm/km: add mkimage config file for uart download
> 
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Acked-by: Heiko Schocher <hs@denx.de>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Detlev Zundel <dzu@denx.de>
> cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  board/keymile/km_arm/kwbimage-uart.cfg |  179
> ++++++++++++++++++++++++++++++++
>  1 files changed, 179 insertions(+), 0 deletions(-)
>  create mode 100644 board/keymile/km_arm/kwbimage-uart.cfg
> 
> diff --git a/board/keymile/km_arm/kwbimage-uart.cfg
> b/board/keymile/km_arm/kwbimage-uart.cfg
> new file mode 100644
> index 0000000..d8c517c
> --- /dev/null
> +++ b/board/keymile/km_arm/kwbimage-uart.cfg
> @@ -0,0 +1,179 @@
> +#
> +# (C) Copyright 2010
> +# Heiko Schocher, DENX Software Engineering, hs at denx.de.
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> +# MA 02110-1301 USA
> +#
> +# Refer docs/README.kwimage for more details about how-to configure
> +# and create kirkwood boot image
> +#
> +
> +# Boot Media configurations
> +BOOT_FROM	uart	# Boot from SPI flash

Comments are wrong here..
I think this is more over debug support. i.e. if you want to bring up broken board with the help of UART.

Does it makes sense to mainline?

Regards..
Prafulla . .

[U-Boot] [PATCH] arm/km: add mkimage config file for uart download

[Valentin Longchamp]

Prafulla Wadaskar wrote:
> 
>> -----Original Message-----
>> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
>> Sent: Friday, April 08, 2011 6:18 PM
>> To: u-boot at lists.denx.de
>> Cc: holger.brunck at keymile.com; hs at denx.de; Valentin Longchamp; Wolfgang
>> Denk; Detlev Zundel; Prafulla Wadaskar
>> Subject: [PATCH] arm/km: add mkimage config file for uart download
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> Acked-by: Heiko Schocher <hs@denx.de>
>> cc: Wolfgang Denk <wd@denx.de>
>> cc: Detlev Zundel <dzu@denx.de>
>> cc: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>>  board/keymile/km_arm/kwbimage-uart.cfg |  179
>> ++++++++++++++++++++++++++++++++
>>  1 files changed, 179 insertions(+), 0 deletions(-)
>>  create mode 100644 board/keymile/km_arm/kwbimage-uart.cfg
>>
>> diff --git a/board/keymile/km_arm/kwbimage-uart.cfg
>> b/board/keymile/km_arm/kwbimage-uart.cfg
>> new file mode 100644
>> index 0000000..d8c517c
>> --- /dev/null
>> +++ b/board/keymile/km_arm/kwbimage-uart.cfg
>> @@ -0,0 +1,179 @@
>> +#
>> +# (C) Copyright 2010
>> +# Heiko Schocher, DENX Software Engineering, hs at denx.de.
>> +#
>> +# See file CREDITS for list of people who contributed to this
>> +# project.
>> +#
>> +# This program is free software; you can redistribute it and/or
>> +# modify it under the terms of the GNU General Public License as
>> +# published by the Free Software Foundation; either version 2 of
>> +# the License, or (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program; if not, write to the Free Software
>> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
>> +# MA 02110-1301 USA
>> +#
>> +# Refer docs/README.kwimage for more details about how-to configure
>> +# and create kirkwood boot image
>> +#
>> +
>> +# Boot Media configurations
>> +BOOT_FROM	uart	# Boot from SPI flash
> 
> Comments are wrong here..
> I think this is more over debug support. i.e. if you want to bring up broken board with the help of UART.

You are right, the comment definitely is wrong here. I will fix this (it 
is the same in the memphis SDRAM patch).

> 
> Does it makes sense to mainline?
> 

We indeed use it for development and debug support. What is your usual 
policy about such config files for marvell boards and u-boot mainlining 
? We will stick to it as well.

-- 
Valentin Longchamp
Embedded Software Engineer
Hardware and Chip Integration
______________________________________
KEYMILE AG
Schwarzenburgstr. 73
CH-3097 Liebefeld
Phone +41 31 377 1318
Fax   +41 31 377 1212
valentin.longchamp at keymile.com
www.keymile.com
______________________________________
KEYMILE: A Specialist as a Partner