public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] cpu9260: update board support
Date: Mon, 11 Apr 2011 13:58:33 +0200	[thread overview]
Message-ID: <4DA2ECE9.1060500@eukrea.com> (raw)
In-Reply-To: <4DA2DD18.4070500@emk-elektronik.de>

Hi Reinhard,

On 11/04/2011 12:51, Reinhard Meyer wrote:
>> +/* to be removed once maemory-map.h is fixed */
>
> That would be "memory-map.h".
> However memory-map.h does not exist anymore.
>
.../...
>
> Please no "1" anymore for just defines, unless the value 1 is really used as a value.
>
.../...
>
> No SZ_ maxros anymore. Please fix globally.
>
please check v2 :
http://patchwork.ozlabs.org/patch/89540/

Thanks,
Eric

  reply	other threads:[~2011-04-11 11:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 22:31 [U-Boot] [PATCH 1/2] mp2usb: remove board support Eric Bénard
2011-01-25 22:31 ` [U-Boot] [PATCH 2/2] cpu9260: update " Eric Bénard
2011-04-11 10:51   ` Reinhard Meyer
2011-04-11 11:58     ` Eric Bénard [this message]
2011-02-02  6:38 ` [U-Boot] [PATCH 1/2] mp2usb: remove " Albert ARIBAUD
2011-04-11 20:44 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA2ECE9.1060500@eukrea.com \
    --to=eric@eukrea.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox