From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?RXJpYyBCw6luYXJk?= <eric@eukrea.com>
Date: Mon, 11 Apr 2011 13:58:33 +0200
Subject: [U-Boot] [PATCH 2/2] cpu9260: update board support
In-Reply-To: <4DA2DD18.4070500@emk-elektronik.de>
References: <1295994684-7431-1-git-send-email-eric@eukrea.com>
	<1295994684-7431-2-git-send-email-eric@eukrea.com>
	<4DA2DD18.4070500@emk-elektronik.de>
Message-ID: <4DA2ECE9.1060500@eukrea.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Reinhard,

On 11/04/2011 12:51, Reinhard Meyer wrote:
>> +/* to be removed once maemory-map.h is fixed */
>
> That would be "memory-map.h".
> However memory-map.h does not exist anymore.
>
.../...
>
> Please no "1" anymore for just defines, unless the value 1 is really used as a value.
>
.../...
>
> No SZ_ maxros anymore. Please fix globally.
>
please check v2 :
http://patchwork.ozlabs.org/patch/89540/

Thanks,
Eric