public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules
Date: Mon, 11 Apr 2011 15:12:37 +0200	[thread overview]
Message-ID: <4DA2FE45.4080701@emk-elektronik.de> (raw)
In-Reply-To: <1296613080-24426-1-git-send-email-ryan@bluewatersys.com>

Dear Ryan Mallon,
> Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> single board computer modules. Includes NAND flash and Ethernet
> support.
> 
> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
> ---
> Patches apply against the rework101229 branch of 
> git://git.denx.de/u-boot-atmel.git.
> 
> Builds and runs. Tested Ethernet and NAND booting.

WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#154: FILE: board/bluewater/snapper9260/snapper9260.c:25:
+#include <asm/io.h>
[ignored]

ERROR: trailing whitespace
#201: FILE: board/bluewater/snapper9260/snapper9260.c:72:
+^Iwritel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | $
[fixed manually]

ERROR: trailing whitespace
#320: FILE: include/configs/snapper9260.h:3:
+ * $
[fixed manually]

WARNING: please, no space before tabs
#356: FILE: include/configs/snapper9260.h:39:
+#define CONFIG_SYS_HZ ^I^I^I1000$
[fixed manually]

ERROR: space required after that close brace '}'
#418: FILE: include/configs/snapper9260.h:101:
+#define CONFIG_SYS_I2C_PCA953X_WIDTH	{{0x28, 16}}
[fixed manually]

ERROR: trailing whitespace
#440: FILE: include/configs/snapper9260.h:123:
+#define I2C_SOFT_DECLARATIONS           $
[fixed manually]

ERROR: space prohibited after that open parenthesis '('
#485: FILE: include/configs/snapper9260.h:168:
+#define CONFIG_SYS_MALLOC_LEN		(  1 << 20)
[fixed manually]

total: 5 errors, 2 warnings, 432 lines checked

Applied to u-boot-atmel/next after fixing style problems.

Thanks,

Reinhard

      parent reply	other threads:[~2011-04-11 13:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02  2:18 [U-Boot] [PATCH v3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules Ryan Mallon
2011-02-07 21:16 ` Ryan Mallon
2011-04-11 13:12 ` Reinhard Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA2FE45.4080701@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox