[U-Boot] [PATCH V2] memcpy/memmove: Do not copy to same address

Wolfgang Denk
2011-05-24T20:39:16Z

Dear Scott Wood,

In message <20110524143749.0b508c66@schlenkerla.am.freescale.net> you wrote:
>
> Might want to pass -fno-delete-null-pointer-checks...

Thanks for pointing out.

> As for memcpy/memmove, if in U-Boot it's to be legal to pass overlapping
> regions to memcpy(), why have separate implementations (not to mention
> bcopy...)?

Define "legal"? Legal as in "everything that is not explicitly
forbidden"? Legal as in "any code that does not exwecute the HCF
instruction"?

The man page says: "The memory areas should not overlap. Use
memmove(3) if the memory areas do overlap." I have nothing to add
here.

As for the different implementations: well, U-Boot imported tons of
code from different sources, using different interfaces and library
functions. Where needed, the missing library functions got added.

Cleanup patches are always welcome.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hegel was right when he said that we learn from history that man can
never learn anything from history. - George Bernard Shaw