From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Wed, 13 Apr 2011 22:23:20 +0200
Subject: [U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC
 address	framework to usbnet
In-Reply-To: <201104122348.23373.vapier@gentoo.org>
References: <1302655572-31544-1-git-send-email-sjg@chromium.org>	<1302655572-31544-2-git-send-email-sjg@chromium.org>
	<201104122348.23373.vapier@gentoo.org>
Message-ID: <4DA60638.8090908@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 13/04/2011 05:48, Mike Frysinger a ?crit :

>>   			if (strchr(dev->name, ' '))
>> -				puts("\nWarning: eth device name has a space!\n");
>> +				puts("\nWarning: eth device name has a "
>> +					"space!\n");
>
> please dont change unrelated things.  that newline should be there, and this
> string shouldnt be broken up.

Technically it is not. A C string constant can be made of several 
quote-delimited string literals separated by whitespace -- so this 
change is a no-op, and does not remove any newline btw. I suspect the 
change is to keep checkpatch.pl happy about the line length.

Amicalement,
-- 
Albert.