From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 14 Apr 2011 07:01:26 +0200 Subject: [U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet In-Reply-To: <201104131706.00229.vapier@gentoo.org> References: <1302655572-31544-1-git-send-email-sjg@chromium.org> <201104122348.23373.vapier@gentoo.org> <4DA60638.8090908@aribaud.net> <201104131706.00229.vapier@gentoo.org> Message-ID: <4DA67FA6.4020506@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 13/04/2011 23:05, Mike Frysinger a ?crit : > On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote: >> Le 13/04/2011 05:48, Mike Frysinger a ?crit : >>>> if (strchr(dev->name, ' ')) >>>> >>>> - puts("\nWarning: eth device name has a space!\n"); >>>> + puts("\nWarning: eth device name has a " >>>> + "space!\n"); >>> >>> please dont change unrelated things. that newline should be there, and >>> this string shouldnt be broken up. >> >> Technically it is not. A C string constant can be made of several >> quote-delimited string literals separated by whitespace -- so this >> change is a no-op, and does not remove any newline btw. I suspect the >> change is to keep checkpatch.pl happy about the line length. > > you truncated my quote which changes things significantly. i wasnt talking > about the string when i said newline. > -mike Sorry about that -- I did truncate indeed, to keep your comment and the change that was immediately before it, which I thought the comment was referring to exclusively. Amicalement, -- Albert.