From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 14 Apr 2011 07:58:32 +0200 Subject: [U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet In-Reply-To: <201104131930.01961.vapier@gentoo.org> References: <1302655572-31544-1-git-send-email-sjg@chromium.org> <201104122348.23373.vapier@gentoo.org> <4DA60638.8090908@aribaud.net> <201104131930.01961.vapier@gentoo.org> Message-ID: <4DA68D08.9070908@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 14/04/2011 01:30, Mike Frysinger a ?crit : > On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote: >> btw. I suspect the change is to keep checkpatch.pl happy about the line >> length. > > also, checkpatch is a tool in the toolbox. people should not be blindly > following it, but reviewing its output to see what should be changed and which > should be ignored. > > if checkpatch is complaining about code that you arent changing, then you > probably shouldnt worry about it. especially when the only thing you're doing > is changing style. I tend to see this "don't worry about some checkpatch.pl messages" appraoch as similar to "don't worry about some C compiler warnings". in that indeed "you probably shouldn't worry about it", and the key is "probably": when it bites you back later on, you realize you "probably" should have worried. If you apply a zero-C-warning policy, then a zero-checkpatch-warning policy makes sense as well... ... with the exception of Linux-centric warning or a coding style warning which would conflict with U-Boot's coding style -- anyone interested in introducing 'flavors' or 'style' in checkpatch.pl, with oone Linux and one U-Boot flavor/style to begin with? So ignoring /some specific/ checkpatch.pl diagnostic is ok, but that's as long as it is established that the specific diagnostic is purely linux-centric" or voluntarily ignored as a coding rule; but then we'd need a list of such 'non-warnings' somewhere on the Wiki, I think, along with a rationale for ignoring it. > -mike Amicalement, -- Albert.