From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Fri, 15 Apr 2011 19:34:48 +0200
Subject: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND
In-Reply-To: <20110413112453.12670f34@schlenkerla.am.freescale.net>
References: <1302372335-30232-1-git-send-email-sbabic@denx.de>
	<1302372335-30232-6-git-send-email-sbabic@denx.de>
	<20110411191647.GC25161@schlenkerla.am.freescale.net>
	<4DA41EFA.4060402@denx.de>
	<20110413112453.12670f34@schlenkerla.am.freescale.net>
Message-ID: <4DA881B8.2080005@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/13/2011 06:24 PM, Scott Wood wrote:

Hi Scott,

> Davinci-specific #defines do not belong in nand_base.c[1].  The controller
> driver should be able to set "this isn't supported" options just as well as
> the chip data -- I just don't think it should be limited to this specific
> one.

surely, but it is not clear to me how. There is no entry for a
write_subpage function, as this issue does not happen with other
controllers, and I do not see a callback for the driver after the
nand_scan() function, where I thought the driver could change the
options according to its capabilities.

> 
> For example, fsl_elbc_nand.c sets NAND_NO_READRDY and NAND_NO_AUTOINCR.
> Before this thread, I didn't realize it they were getting ignored.
>  Things
> work anyway because the former is an optimization, and the latter is getting
> forced on after the masking, for some reason -- does autoincr simply not
> work?  Can we remove the code? :-)

Well, the options are simply ignored, I agree about removing them.

> 
> -Scott
> 
> [1] Nor should it be turned back into a non-davinci define -- what if there
> are multiple NAND controllers supported, and only one requires this?  It's
> not so bad in U-Boot (I'd still rather avoid it though), but this approach
> is not going to go over well in Linux.
> 
> How is Linux handling this?

What I have seen (kernel 2.6.38), the options are ignored in Linux as
well, and this issue is open for the davinci processors.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================