From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 16 Apr 2011 08:22:49 +0200 Subject: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch In-Reply-To: <20110415100912.1A7B41537B0@gemini.denx.de> References: <1302850978-2954-1-git-send-email-macpaul@andestech.com> <201104150400.36877.vapier@gentoo.org> <201104150453.21441.vapier@gentoo.org> <20110415100912.1A7B41537B0@gemini.denx.de> Message-ID: <4DA935B9.6070807@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi all, Le 15/04/2011 12:09, Wolfgang Denk a ?crit : > Dear Mike Frysinger, > > In message<201104150453.21441.vapier@gentoo.org> you wrote: >> >>>> On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: >>>>> #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \ >>>>> - !defined(CONFIG_ENV_IS_IN_FLASH)&& \ >>>>> + !defined(CONFIG_ENV_IS_IN_FLASH)&& \ >>>> >>>> not sure this one hunk is desirable, but the rest are fine >>>> -mike >>> >>> Do you mean the replacement with space to ident? >>> >>> According to the 2.6.38.1's checkpatch, it reported: >>> WARNING: please, no spaces at the start of a line >> >> this particular check has already been posted upstream as generally causing >> more harm than good. but getting checkpatch fixed often feels glacial. Been there too, once. :( >> up to Wolfgang how he feels about ifdef indentation > > In this specific case of #ifdef indentation I feel that the original > form (which causes checkpatch warnings) is actually easier to read, so > I tend to keep it. But I am aware that this is inconsequent as we ask > for "indentation by TAB only" everywhere else. > > So I'm really torn - if it was for myself only I would not hesitate to > leave this part as is, but I realize that quite a number of users have > already complained about the unclear rules and exceptions we make with > the coding style requirements, and some actually threw in the sponge > because of that. > > I'm afraid I'm not much of help here. If the goal is to have the !defined aligned, then maybe a solution here would be toput a tab rather than a space after the #if? > Best regards, > > Wolfgang Denk Amicalement, -- Albert.