public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch
Date: Sat, 16 Apr 2011 17:07:06 +1000	[thread overview]
Message-ID: <4DA9401A.2010600@gmail.com> (raw)
In-Reply-To: <4DA935B9.6070807@aribaud.net>

On 16/04/11 16:22, Albert ARIBAUD wrote:
> Hi all,
> 
> Le 15/04/2011 12:09, Wolfgang Denk a ?crit :
>> Dear Mike Frysinger,
>>
>> In message<201104150453.21441.vapier@gentoo.org>  you wrote:
>>>
>>>>> On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote:
>>>>>>   #if !defined(CONFIG_ENV_IS_IN_EEPROM)&&  \
>>>>>> -    !defined(CONFIG_ENV_IS_IN_FLASH)&&  \
>>>>>> +     !defined(CONFIG_ENV_IS_IN_FLASH)&&  \
>>>>>

[snip]

> 
> If the goal is to have the !defined aligned, then maybe a solution here 
> would be toput a tab rather than a space after the #if?
> 

I agree - Aligned looks cleaner and easier to read (especially if the logic
is multi-levelled) and shutting up checkpatch by using a tab rather than a
space is an easy solution

But, fwiw, once the patch is applied and everything is nicely aligned and
reads well, who's going to care that checkpatch complained?

Regards,

Graeme

  reply	other threads:[~2011-04-16  7:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15  7:02 [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch Macpaul Lin
2011-04-15  8:00 ` Mike Frysinger
2011-04-15  8:25   ` Macpaul Lin
2011-04-15  8:53     ` Mike Frysinger
2011-04-15  8:57       ` Macpaul Lin
2011-04-15 10:09       ` Wolfgang Denk
2011-04-15 10:18         ` Mike Frysinger
2011-04-16  6:18           ` Macpaul Lin
2011-04-16  6:35             ` Albert ARIBAUD
2011-04-16  6:22         ` Albert ARIBAUD
2011-04-16  7:07           ` Graeme Russ [this message]
2011-04-16 11:17             ` Macpaul Lin
2011-04-16 12:55               ` Albert ARIBAUD
2011-04-25  8:55               ` [U-Boot] [PATCH v2] " Macpaul Lin
2011-04-27 10:11                 ` Detlev Zundel
2011-04-27 10:53                   ` Macpaul Lin
2011-04-27  2:16               ` [U-Boot] [PATCH v3] " Macpaul Lin
2011-04-27 14:44                 ` Detlev Zundel
2011-04-27 14:49                   ` Macpaul Lin
2011-04-30 20:27                 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA9401A.2010600@gmail.com \
    --to=graeme.russ@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox