From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Russ Date: Sat, 16 Apr 2011 17:07:06 +1000 Subject: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch In-Reply-To: <4DA935B9.6070807@aribaud.net> References: <1302850978-2954-1-git-send-email-macpaul@andestech.com> <201104150400.36877.vapier@gentoo.org> <201104150453.21441.vapier@gentoo.org> <20110415100912.1A7B41537B0@gemini.denx.de> <4DA935B9.6070807@aribaud.net> Message-ID: <4DA9401A.2010600@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16/04/11 16:22, Albert ARIBAUD wrote: > Hi all, > > Le 15/04/2011 12:09, Wolfgang Denk a ?crit : >> Dear Mike Frysinger, >> >> In message<201104150453.21441.vapier@gentoo.org> you wrote: >>> >>>>> On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: >>>>>> #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \ >>>>>> - !defined(CONFIG_ENV_IS_IN_FLASH)&& \ >>>>>> + !defined(CONFIG_ENV_IS_IN_FLASH)&& \ >>>>> [snip] > > If the goal is to have the !defined aligned, then maybe a solution here > would be toput a tab rather than a space after the #if? > I agree - Aligned looks cleaner and easier to read (especially if the logic is multi-levelled) and shutting up checkpatch by using a tab rather than a space is an easy solution But, fwiw, once the patch is applied and everything is nicely aligned and reads well, who's going to care that checkpatch complained? Regards, Graeme