[U-Boot] [PATCH v2 2/3] arm: omap: innovator: Prepare for mach-types.h changes

Igor Grinberg
2011-05-03T13:00:01Z

Hi Wolfgang,

On 05/03/11 15:29, Wolfgang Denk wrote:
> Dear Igor Grinberg,
>
> In message <1304417333-30745-1-git-send-email-grinberg@compulab.co.il> you wrote:
>> This board used machine_is_* macros for identifying the arch number.
>> Fix this by introducing a board specific configuration variable.
>>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>> v2: remove the ifdeferry by introducing config variable,
>> Alessandro, what about this one?
> ...
>> + gd->bd->bi_arch_number = CONFIG_BOARD_MACH_TYPE;
> In principle this is OK, but why do you invent yet another new CONFIG_
> variable (and without documenting it) ?

Well, it was meant to be board specific, so local documentation in
config file should be enough.

> We have a number of boards that already use a similar construct with
> CONFIG_MACH_TYPE, so I suggest you do the same.

Didn't know that, I though it is new... silly me... ;)
Thanks for pointing.

> And while being there, could you please also add a description for
> CONFIG_MACH_TYPE to the README? Thanks!

I'll try my best, but this will take a while...

Other patches in this series are not affected by this one,
so can be easily applied.

--
Regards,
Igor.