[U-Boot] [PATCH v2 2/3] arm: omap: innovator: Prepare for mach-types.h changes

Wolfgang Denk
2011-05-03T12:29:54Z

Dear Igor Grinberg,

In message <1304417333-30745-1-git-send-email-grinberg@compulab.co.il> you wrote:
> This board used machine_is_* macros for identifying the arch number.
> Fix this by introducing a board specific configuration variable.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> v2: remove the ifdeferry by introducing config variable,
> Alessandro, what about this one?
...
> + gd->bd->bi_arch_number = CONFIG_BOARD_MACH_TYPE;

In principle this is OK, but why do you invent yet another new CONFIG_
variable (and without documenting it) ?

We have a number of boards that already use a similar construct with
CONFIG_MACH_TYPE, so I suggest you do the same.

And while being there, could you please also add a description for
CONFIG_MACH_TYPE to the README? Thanks!

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If the car industry behaved like the computer industry over the last
30 years, a Rolls-Royce would cost $5, get 300 miles per gallon, and
blow up once a year killing all passengers inside.