From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Ceresoli Date: Tue, 19 Apr 2011 23:56:54 +0200 Subject: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote" In-Reply-To: References: <1302796377-3321-1-git-send-email-luca.ceresoli@comelit.it> <1303143594-5345-4-git-send-email-luca.ceresoli@comelit.it> <4DADAA50.1040008@comelit.it> Message-ID: <4DAE0526.5080200@lucaceresoli.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, just a few e-mails ago along this thread Albert Aribaud wrote: > My opinion is that you should make sure that at least the code you touch > is checkpatch-clean, so yes, you should fix that; but there is no need > to submit 'checkpatch-compliance' patches. Just fix the line here so > that checkpatch does not complain. So I proceeded along that way. Now Detlev Zundel wrote: > ... > Hm, I see. Still, can we have one commit (with "cosmetic" in the > changelog) that silences checkpatch but does not have any functional > changes? We really try hard to separate cosmetic from functional > changes. This makes reviewing (and debugging) so much easier. While I appreciate the careful review of my patches, I cannot hide that it is discouraging for new contributors to be requested for contradictory modifications. There should be one precise policy, and that should be clearly documented. http://www.denx.de/wiki/U-Boot/CodingStyle is the place where I would expect to find it. Luca