* [U-Boot] [PATCH] ARM: fix stack pointer adjustment in board_init_f()
@ 2011-04-14 22:32 Eric Cooper
2011-04-15 8:42 ` Wolfgang Denk
0 siblings, 1 reply; 3+ messages in thread
From: Eric Cooper @ 2011-04-14 22:32 UTC (permalink / raw)
To: u-boot
Since addr_sp is a byte address, it should be adjusted by 12 here.
Signed-off-by: Eric Cooper <ecc@cmu.edu>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
arch/arm/lib/board.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index dc46e21..d5b34ad 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -399,7 +399,7 @@ void board_init_f (ulong bootflag)
CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ, addr_sp);
#endif
/* leave 3 words for abort-stack */
- addr_sp -= 3;
+ addr_sp -= 12;
/* 8-byte alignment for ABI compliance */
addr_sp &= ~0x07;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ARM: fix stack pointer adjustment in board_init_f()
2011-04-14 22:32 [U-Boot] [PATCH] ARM: fix stack pointer adjustment in board_init_f() Eric Cooper
@ 2011-04-15 8:42 ` Wolfgang Denk
2011-04-20 5:50 ` Albert ARIBAUD
0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2011-04-15 8:42 UTC (permalink / raw)
To: u-boot
Dear Eric Cooper,
In message <1302820357-30318-1-git-send-email-ecc@cmu.edu> you wrote:
> Since addr_sp is a byte address, it should be adjusted by 12 here.
>
> Signed-off-by: Eric Cooper <ecc@cmu.edu>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> arch/arm/lib/board.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Wolfgang Denk <wd@denx.de>
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You've no idea of what a poor opinion I have of myself, and how
little I deserve it. - W. S. Gilbert
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ARM: fix stack pointer adjustment in board_init_f()
2011-04-15 8:42 ` Wolfgang Denk
@ 2011-04-20 5:50 ` Albert ARIBAUD
0 siblings, 0 replies; 3+ messages in thread
From: Albert ARIBAUD @ 2011-04-20 5:50 UTC (permalink / raw)
To: u-boot
Hi Eric,
Le 15/04/2011 10:42, Wolfgang Denk a ?crit :
> Dear Eric Cooper,
>
> In message<1302820357-30318-1-git-send-email-ecc@cmu.edu> you wrote:
>> Since addr_sp is a byte address, it should be adjusted by 12 here.
>>
>> Signed-off-by: Eric Cooper<ecc@cmu.edu>
>> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
>> ---
>> arch/arm/lib/board.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Acked-by: Wolfgang Denk<wd@denx.de>
>
> Best regards,
>
> Wolfgang Denk
Applied to u-boot-arm, thanks.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-20 5:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-14 22:32 [U-Boot] [PATCH] ARM: fix stack pointer adjustment in board_init_f() Eric Cooper
2011-04-15 8:42 ` Wolfgang Denk
2011-04-20 5:50 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox