From: Daniel Gorsulowski <Daniel.Gorsulowski@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH-V2 2/2] at91: reworked support for otc570 board
Date: Wed, 20 Apr 2011 08:47:27 +0200 [thread overview]
Message-ID: <4DAE817F.3070200@esd.eu> (raw)
In-Reply-To: <4DADB833.2030502@emk-elektronik.de>
Hello Reinhard,
Reinhard Meyer wrote:
> Am 18.04.2011 16:15, schrieb Daniel Gorsulowski:
>> The otc570 board support was broken. Within this opportunity, I completely
>> reworked the board files.
>>
>> Signed-off-by: Daniel Gorsulowski <Daniel.Gorsulowski@esd.eu>
>> ---
>>
>> This patch is based on u-boot-atmel/rework101229 branch (minus the last 5
>> patches) plus the 'at91: fixed at91sam9263 system file' patch in
>> u-boot-atmel/next branch.
>>
>> V2: -fixed commit description
>>
>> board/esd/otc570/config.mk | 1 -
>> board/esd/otc570/otc570.c | 106 ++++++++++--------
>> boards.cfg | 3 +-
>> include/configs/otc570.h | 265 +++++++++++++++++++++++++-------------------
>> 4 files changed, 211 insertions(+), 164 deletions(-)
>> delete mode 100644 board/esd/otc570/config.mk
>
> This patch had several places with <space><tab> or <start of line><space>.
>
> I removed them manually. Please, next time run your patches through
> <linux>/scripts/checkpatch.pl. Thanks.
Sorry, but I checked my patches by checkpatch.pl. Maybe you can explain
me, what I did wrong?
danielg at debby:~/git/u-boot-atmel$
../linux/linux-2.6/scripts/checkpatch.pl
0002-at91-reworked-support-for-otc570-board.patch
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#48: FILE: board/esd/otc570/otc570.c:30:
+#include <asm/io.h>
ERROR: Macros with complex values should be enclosed in parenthesis
#578: FILE: include/configs/otc570.h:209:
+# define CONFIG_SYS_NAND_ENABLE_PIN AT91_PIO_PORTD, 15
ERROR: Macros with complex values should be enclosed in parenthesis
#579: FILE: include/configs/otc570.h:210:
+# define CONFIG_SYS_NAND_READY_PIN AT91_PIO_PORTA, 22
total: 2 errors, 1 warnings, 610 lines checked
0002-at91-reworked-support-for-otc570-board.patch has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
>
> Applied to u-boot-atmel/next.
Thank you!
>
> Best Regards,
>
> Reinhard
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
--
Mit freundlichen Gr??en
Daniel Gorsulowski
-------------------------------------------------------------------------
B.Eng. Daniel Gorsulowski
System-Design
esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Telefon: 0511-37298-192 - Fax: 0511-37298-68
Bitte besuchen Sie uns im Internet unter http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------
prev parent reply other threads:[~2011-04-20 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 14:15 [U-Boot] [PATCH-V2 2/2] at91: reworked support for otc570 board Daniel Gorsulowski
2011-04-19 16:28 ` Reinhard Meyer
2011-04-20 6:47 ` Daniel Gorsulowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAE817F.3070200@esd.eu \
--to=daniel.gorsulowski@esd.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox