From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Date: Thu, 21 Apr 2011 09:29:43 +0300 Subject: [U-Boot] [PATCH v3] USB: Remove __attribute__ ((packed)) for struct ehci_hccr and ehci_hcor In-Reply-To: <1303343572-19972-28-git-send-email-jkridner@beagleboard.org> References: <1303343572-19972-1-git-send-email-jkridner@beagleboard.org> <1303343572-19972-15-git-send-email-jkridner@beagleboard.org> <1303343572-19972-16-git-send-email-jkridner@beagleboard.org> <1303343572-19972-17-git-send-email-jkridner@beagleboard.org> <1303343572-19972-18-git-send-email-jkridner@beagleboard.org> <1303343572-19972-19-git-send-email-jkridner@beagleboard.org> <1303343572-19972-20-git-send-email-jkridner@beagleboard.org> <1303343572-19972-21-git-send-email-jkridner@beagleboard.org> <1303343572-19972-22-git-send-email-jkridner@beagleboard.org> <1303343572-19972-23-git-send-email-jkridner@beagleboard.org> <1303343572-19972-24-git-send-email-jkridner@beagleboard.org> <1303343572-19972-25-git-send-email-jkridner@beagleboard.org> <1303343572-19972-26-git-send-email-jkridner@beagleboard.org> <1303343572-19972-27-git-send-email-jkridner@beagleboard.org> <1303343572-19972-28-git-send-email-jkridner@beagleboard.org> Message-ID: <4DAFCED7.9010207@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/21/11 02:52, Jason Kridner wrote: > Remove __attribute__ ((packed)) to prevent byte access to soc > registers in some gcc versions. > > Having patches to enable ehci for the BeagleBoard lying around for > several month, this one was the show-stopper. > > Credits have to go to Laine Walker-Avina for > finding the problem. > > Signed-off-by: Jason Kridner > Cc: Alexander Holler > Cc: Sandeep Paulraj > --- > Changes for v2: > * Original and v2 were provided by Alexander Holler. > * v1 was http://patchwork.ozlabs.org/patch/89358/ > * v2 was http://patchwork.ozlabs.org/patch/89362/ > > Changes for v3: > * Switched to align(4), rather than remove the attribute, per suggestion > from Alexander. Also fixing the commit message would help as the change log won't be available after the patch applied. > --- > drivers/usb/host/ehci.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index 945ab64..3d0ad0c 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -55,7 +55,7 @@ struct ehci_hccr { > #define HCS_N_PORTS(p) (((p) >> 0) & 0xf) > uint32_t cr_hccparams; > uint8_t cr_hcsp_portrt[8]; > -} __attribute__ ((packed)); > +} __attribute__ ((packed, aligned(4))); > > struct ehci_hcor { > uint32_t or_usbcmd; > @@ -85,7 +85,7 @@ struct ehci_hcor { > #define FLAG_CF (1 << 0) /* true: we'll support "high speed" */ > uint32_t or_portsc[CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS]; > uint32_t or_systune; > -} __attribute__ ((packed)); > +} __attribute__ ((packed, aligned(4))); > > #define USBMODE 0x68 /* USB Device mode */ > #define USBMODE_SDIS (1 << 3) /* Stream disable */ -- Regards, Igor.