From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] RFC: getramsize() prototype and volatile qualifier
Date: Thu, 21 Apr 2011 09:09:40 +0200 [thread overview]
Message-ID: <4DAFD834.8010303@aribaud.net> (raw)
Hi all,
Call it a detail, but I see that get_ram_size() calls sometime qualify
their argument as volatile and sometimes not, and this makes checkpatch
complain that volatiles are Bad(tm), which I would like to get fixed.
The prototype for get_ram_size() in is
long get_ram_size (volatile long *, long);
While I understand that the way get_ram_size() works, it needs to
perform volatile *accesses* to addresses computed from its arguments, I
don't see why it requires one of the arguments themselves to be volatile.
Am I missing something here, particularly about some toolchain requiring
the argument to be volatile? I see no reason it should, but better safe
than sorry.
Amicalement,
--
Albert.
next reply other threads:[~2011-04-21 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 7:09 Albert ARIBAUD [this message]
2011-04-21 17:02 ` [U-Boot] RFC: getramsize() prototype and volatile qualifier Mike Frysinger
2011-04-21 17:50 ` Albert ARIBAUD
2011-04-21 22:28 ` Mike Frysinger
2011-04-22 5:52 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAFD834.8010303@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox