public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version
Date: Thu, 21 Apr 2011 18:01:06 +0200	[thread overview]
Message-ID: <4DB054C2.4020901@denx.de> (raw)
In-Reply-To: <4DA8897B.70202@denx.de>

On 04/15/2011 08:07 PM, Stefano Babic wrote:
> On 04/12/2011 04:18 AM, Fabio Estevam wrote:
>> Use the same method of the Linux kernel to print the MX31 silicon version on 
>> boot.
>>
>> Tested on a MX31PDK with a 2.0 silicon, where it shows:
>>
>> CPU:   Freescale i.MX31 rev 2.0 at 531 MHz
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
> 
> Applied to u-boot-imx, thanks.
> 

Fabio,

I have not noted before that your patch introduce a warning:

generic.c: In function 'get_cpu_rev':
generic.c:131: warning: return discards qualifiers from pointer target type

This is due to the usage of the const in the mx3_cpu_type:

struct mx3_cpu_type {
        u8 srev;
       const char *v;

Do you agree if I drop myself the const attribute on u-boot-imx before
pulling your patch to the arm tree ?

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2011-04-21 16:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  2:18 [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version Fabio Estevam
2011-04-14 11:14 ` Albert ARIBAUD
2011-04-14 20:53   ` stefano babic
2011-04-15 18:07 ` Stefano Babic
2011-04-21 16:01   ` Stefano Babic [this message]
2011-04-27  9:11     ` Detlev Zundel
2011-04-27  9:40       ` Stefano Babic
2011-04-27 13:16         ` Fabio Estevam
2011-04-27 14:00           ` Stefano Babic
2011-04-27 14:57         ` Detlev Zundel
2011-04-27 16:01           ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB054C2.4020901@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox