From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND
Date: Fri, 22 Apr 2011 09:13:34 +0200 [thread overview]
Message-ID: <4DB12A9E.2040709@denx.de> (raw)
In-Reply-To: <20110415152903.4ee513aa@schlenkerla.am.freescale.net>
On 04/15/2011 10:29 PM, Scott Wood wrote:
>
> nand_scan() is broken into head and tail functions. In Linux, the driver
> calls these, and can look at the chip info before tail is called. In
> U-boot, common code drives this, and the controller driver is not involved
> -- but it would be good to change this.
Agree, we can do in this way.
>
>>> For example, fsl_elbc_nand.c sets NAND_NO_READRDY and NAND_NO_AUTOINCR.
>>> Before this thread, I didn't realize it they were getting ignored.
>>> Things
>>> work anyway because the former is an optimization, and the latter is getting
>>> forced on after the masking, for some reason -- does autoincr simply not
>>> work? Can we remove the code? :-)
>>
>> Well, the options are simply ignored, I agree about removing them.
>
> I think it can be enabled by the controller driver between head and tail
> (at least on Linux), though I don't see any drivers that do this as far as
> a quick grep shows.
The only point is we need that the controller checks the parameters
after the tail part, as the tail part scans the chip and sets its
options, as the SUBPAGE flag. We could add a pre_adjust() and
post_adjust() functions to be called after the head and tail part of the
nand_scan().
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-04-22 7:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 18:05 [U-Boot] [PATCH 1/6] Davinci: ea20: set console on UART0 Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 2/6] Davinci: ea20: set GPIOs to hold MII-Phy in reset and set UART0-Switch for console Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 3/6] Davinci: ea20: Add NAND support Stefano Babic
2011-04-11 13:05 ` Ben Gardiner
2011-04-12 7:29 ` Stefano Babic
2011-04-12 16:09 ` Ben Gardiner
2011-04-09 18:05 ` [U-Boot] [PATCH 4/6] Davinci: ea20: Add early init to get early output from console Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 5/6] Davinci: ea20: Add default U-Boot environment Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND Stefano Babic
2011-04-11 14:04 ` Ben Gardiner
2011-04-12 0:45 ` Jon Povey
2011-04-12 9:08 ` Stefano Babic
2011-04-12 12:47 ` Ben Gardiner
2011-04-11 19:16 ` Scott Wood
2011-04-12 9:44 ` Stefano Babic
2011-04-13 16:24 ` Scott Wood
2011-04-15 17:34 ` Stefano Babic
2011-04-15 20:29 ` Scott Wood
2011-04-22 7:13 ` Stefano Babic [this message]
2011-04-25 17:37 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB12A9E.2040709@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox