From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 22 Apr 2011 16:11:04 +0200 Subject: [U-Boot] [PATCH V6 2/3] PMIC: Add dialog pmic support In-Reply-To: <1303476945-17383-3-git-send-email-jason.hui@linaro.org> References: <1303476945-17383-1-git-send-email-jason.hui@linaro.org> <1303476945-17383-3-git-send-email-jason.hui@linaro.org> Message-ID: <4DB18C78.6030103@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/22/2011 02:55 PM, Jason Liu wrote: > Add dialog pmic(DA9053) driver with I2C interface support > Hi Jason, > diff --git a/drivers/misc/dialog_pmic.c b/drivers/misc/dialog_pmic.c > new file mode 100644 > index 0000000..95dc6ea > --- /dev/null > +++ b/drivers/misc/dialog_pmic.c > @@ -0,0 +1,123 @@ > +/* > + * (C) Copyright 2011 Freescale Semiconductor, Inc. > + * Based on drivers/misc/fsl_pmic.c As I can see now, this driver is quite a copy of fsl_pmic.c, with slightly changes. Are you sure we cannot simply change the already provided driver, adding support for the new chip ? I have not read the DA9053 datasheet, but from your patch it seems to me that the relevant changes are: - registers are 1 byte wide instead of 32 bit - different size of register area Really not enough to justify a new driver. All functions are really copied from the old one. Please consider to adapt fsl_pmic.c instead of adding a slightly different new one. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================