From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Mon, 25 Apr 2011 09:38:35 +0200
Subject: [U-Boot] [PATCH v3] Don't grab memory for LCD if FB address is
 defined
In-Reply-To: <20110424232755.C2225D5269F@gemini.denx.de>
References: <4D75B591.3040605@samsung.com>	<20110313195021.1B4D4E0CE97@gemini.denx.de>	<AANLkTiks=f-C8PsMSQm0bQj53upHj4Aa0i39qXe5ayxS@mail.gmail.com>	<4D7F24C3.9060006@samsung.com>
	<4D8B576B.3030507@free.fr>	<4D8BE6BD.2090101@samsung.com>
	<20110424232755.C2225D5269F@gemini.denx.de>
Message-ID: <4DB524FB.9010905@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 25/04/2011 01:27, Wolfgang Denk a ?crit :
> Dear Minkyu Kang,
>
> In message<4D8BE6BD.2090101@samsung.com>  you wrote:
>> If FB address is defined specific address then don't grab memory for LCD
>>
>> Signed-off-by: Minkyu Kang<mk7.kang@samsung.com>
>> Cc: Albert Aribaud<albert.aribaud@free.fr>
>> Cc: Wolfgang Denk<wd@denx.de>
>> Cc: Stefan Roese<sr@denx.de>
>> Cc: Kim Phillips<kim.phillips@freescale.com>
>> Cc: Andy Fleming<afleming@gmail.com>
>> Cc: Kumar Gala<kumar.gala@freescale.com>
> ...
>> --- /dev/null
>> +++ b/doc/README.fb_addr
>> @@ -0,0 +1,17 @@
>> +Define CONFIG_FB_ADDR if you want to use specific address for frame buffer.
>> +Then system will reserve the frame buffer address to defined address instead of
>> +lcd_setmem (this function grab the memory for frame buffer by panel's size).
>> +
>> +Please see below code (in board_init_f function from arch/arm/lib/board.c)
>> +
>> +#ifdef CONFIG_FB_ADDR
>> +	gd->fb_base = CONFIG_FB_ADDR;
>> +#else
>> +	/* reserve memory for LCD display (always full pages) */
>> +	addr = lcd_setmem (addr);
>> +	gd->fb_base = addr;
>> +#endif /* CONFIG_FB_ADDR */
>> +
>> +If you want this config option then please define it at your board config file
>> +
>> +#define CONFIG_FB_ADDR		0x00000000
>
> Sorry for the late review, but it makes littel sense to add individual
> README.* files for each and every CONFIG option.  Please add the
> documentation (with a little less verbocity) to the top level README
> instead.

Minkyu: can you provide an quick-updated patch with the doc in the top 
level README? I'll rebase and replace accordingly.

> Best regards,
>
> Wolfgang Denk

Amicalement,
-- 
Albert.