[U-Boot] [PATCH 1/7] Orion5x: Correct DRAM bank detection

Prafulla Wadaskar
2011-03-18T10:52:03Z

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
> On Behalf Of rogan at dawes.za.net
> Sent: Friday, March 18, 2011 1:40 PM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH 1/7] Orion5x: Correct DRAM bank detection
>

Some more explanation about the patch may find help full.
Please have a practice to provide some detailed comments.

> From: Rogan Dawes <rogan@dawes.za.net>
>
> ---
> arch/arm/cpu/arm926ejs/orion5x/dram.c | 2 +-
> arch/arm/include/asm/arch-orion5x/orion5x.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/orion5x/dram.c
> b/arch/arm/cpu/arm926ejs/orion5x/dram.c
> index b749282..2ae8f48 100644
> --- a/arch/arm/cpu/arm926ejs/orion5x/dram.c
> +++ b/arch/arm/cpu/arm926ejs/orion5x/dram.c
> @@ -38,7 +38,7 @@ u32 orion5x_sdram_bar(enum memory_bank bank)
> {
> struct orion5x_ddr_addr_decode_registers *winregs =
> (struct orion5x_ddr_addr_decode_registers *)
> - ORION5X_CPU_WIN_BASE;
> + ORION5X_DRAM_BASE;

Any explanation about previous definition was wrong?
Does struct orion5x_ddr_addr_decode_registers still valid for this change?

Regards..
Prafulla . .