[U-Boot] [PATCH 1/7] Orion5x: Correct DRAM bank detection

Rogan Dawes
2011-03-18T11:40:21Z

On 2011/03/18 12:52 PM, Prafulla Wadaskar wrote:
>
>
>> -----Original Message-----
>> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
>> On Behalf Of rogan at dawes.za.net
>> Sent: Friday, March 18, 2011 1:40 PM
>> To: u-boot at lists.denx.de
>> Subject: [U-Boot] [PATCH 1/7] Orion5x: Correct DRAM bank detection
>>
>
> Some more explanation about the patch may find help full.
> Please have a practice to provide some detailed comments.

Hi Prafulla,

My apologies.

The register which was being read was the wrong register entirely.

For the common case where there was just one bank, it coincidentally
returned the right answer anyway (0), but if we tried to detect multiple
banks, the rest were totally wrong.

There is a parallel patch from Michael Spang, which does basically the
same thing. See message-id:
AANLkTinpqD97sYeLQKiGnB05PtJHUFUBh=T+Nx1+THau at mail.gmail.com

Regards,

Rogan