From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MX53: Handle silicon revision 2.1 case
Date: Tue, 26 Apr 2011 10:37:41 +0200 [thread overview]
Message-ID: <4DB68455.9080303@denx.de> (raw)
In-Reply-To: <1303778789-13423-1-git-send-email-festevam@gmail.com>
On 04/26/2011 02:46 AM, Fabio Estevam wrote:
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/cpu/armv7/mx5/soc.c | 3 +++
> arch/arm/include/asm/arch-mx5/imx-regs.h | 1 +
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
Hi Fabio,
> diff --git a/arch/arm/cpu/armv7/mx5/soc.c b/arch/arm/cpu/armv7/mx5/soc.c
> index 6f4e8db..fa7ee6d 100644
> --- a/arch/arm/cpu/armv7/mx5/soc.c
> +++ b/arch/arm/cpu/armv7/mx5/soc.c
> @@ -69,6 +69,9 @@ u32 get_cpu_rev(void)
> case 0x20:
> system_rev |= CHIP_REV_2_0;
> break;
> + case 0x21:
> + system_rev |= CHIP_REV_2_1;
> + break;
At the moment it seems to me that the revision number corresponds 1:1 to
the value of the register in the i.MX53, and we do not need some mapping
as for i.MX51. What about to drop the switch and adding a simpler:
if (reg < 0x20)
system_rev |= CHIP_REV_1_0;
else
system_rev |= reg;
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
=====================================================================
prev parent reply other threads:[~2011-04-26 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 0:46 [U-Boot] [PATCH] MX53: Handle silicon revision 2.1 case Fabio Estevam
2011-04-26 8:37 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB68455.9080303@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox