From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 26 Apr 2011 10:37:41 +0200 Subject: [U-Boot] [PATCH] MX53: Handle silicon revision 2.1 case In-Reply-To: <1303778789-13423-1-git-send-email-festevam@gmail.com> References: <1303778789-13423-1-git-send-email-festevam@gmail.com> Message-ID: <4DB68455.9080303@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/26/2011 02:46 AM, Fabio Estevam wrote: > Signed-off-by: Fabio Estevam > --- > arch/arm/cpu/armv7/mx5/soc.c | 3 +++ > arch/arm/include/asm/arch-mx5/imx-regs.h | 1 + > 2 files changed, 4 insertions(+), 0 deletions(-) > Hi Fabio, > diff --git a/arch/arm/cpu/armv7/mx5/soc.c b/arch/arm/cpu/armv7/mx5/soc.c > index 6f4e8db..fa7ee6d 100644 > --- a/arch/arm/cpu/armv7/mx5/soc.c > +++ b/arch/arm/cpu/armv7/mx5/soc.c > @@ -69,6 +69,9 @@ u32 get_cpu_rev(void) > case 0x20: > system_rev |= CHIP_REV_2_0; > break; > + case 0x21: > + system_rev |= CHIP_REV_2_1; > + break; At the moment it seems to me that the revision number corresponds 1:1 to the value of the register in the i.MX53, and we do not need some mapping as for i.MX51. What about to drop the switch and adding a simpler: if (reg < 0x20) system_rev |= CHIP_REV_1_0; else system_rev |= reg; Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================