public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V6 2/3] PMIC: Add dialog pmic support
Date: Tue, 26 Apr 2011 14:02:10 +0200	[thread overview]
Message-ID: <4DB6B442.8040407@denx.de> (raw)
In-Reply-To: <BANLkTi=gcEJHbMyV_Pnkps8QQiUXW4iF0g@mail.gmail.com>

On 04/25/2011 04:59 AM, Jason Hui wrote:
> Hi, Stefano,

Hi Jason,

>>> If you still want me to include the DA9053 support into fsl_pmic,
>>> could you please
>>> extend the fsl_pmic support to easily add another vender's pmic support first?
>>
>> Really I have not understood your question. What do you mean ?
> 
> Then, Can you tell me how to add the dialog pmic support into
> fsl_pmi.c file which is dedicated for
> freescale mc13xxx? Thanks,

IMHO the details for each Power Controllers are inside the corresponding
header, that contains the register description, in your xace DA09053.h.
The fsl_pmic.c expones only a general way to speak with the controller
via SPI or I2C interface. If I see your patch, the only real difference
with the original file is that a single byte is read/written with the
DA09053, while the mc13xxx have 32-bit registers. You can add this
option as CONFIG_ switch, or in another way.

Only the board is aware about which PMIC is used. In fact, the
fsl_pmic.c does not include neither mc13892.h nor mc13783.h.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2011-04-26 12:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 12:55 [U-Boot] [PATCH V2 1/1] mx5: board: code clean up for checkboard code Jason Liu
2011-04-22 12:55 ` [U-Boot] [PATCH V6 1/3] MX5: clock: Add clock config interface Jason Liu
2011-04-22 12:55 ` [U-Boot] [PATCH V6 2/3] PMIC: Add dialog pmic support Jason Liu
2011-04-22 14:11   ` Stefano Babic
2011-04-22 14:50     ` Jason Liu
2011-04-23  7:45       ` stefano babic
2011-04-25  2:59         ` Jason Hui
2011-04-26 12:02           ` Stefano Babic [this message]
2011-04-27  9:39             ` Detlev Zundel
2011-04-27  9:44               ` Stefano Babic
2011-05-10  5:39                 ` Jason Liu
2011-05-10  8:35                   ` Stefano Babic
2011-05-10  8:42                     ` Jason Hui
2011-04-23 18:53       ` Wolfgang Denk
2011-04-22 12:55 ` [U-Boot] [PATCH V6 3/3] MX53: support for freescale MX53LOCO board Jason Liu
2011-05-11  7:16 ` [U-Boot] [PATCH V2 1/1] mx5: board: code clean up for checkboard code Jason Liu
2011-05-16  5:48   ` Jason Liu
2011-05-16  6:14     ` Stefano Babic
2011-05-16  6:16 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB6B442.8040407@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox