From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 26 Apr 2011 14:02:10 +0200 Subject: [U-Boot] [PATCH V6 2/3] PMIC: Add dialog pmic support In-Reply-To: References: <1303476945-17383-1-git-send-email-jason.hui@linaro.org> <1303476945-17383-3-git-send-email-jason.hui@linaro.org> <4DB18C78.6030103@denx.de> <4DB283B7.8030704@denx.de> Message-ID: <4DB6B442.8040407@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/25/2011 04:59 AM, Jason Hui wrote: > Hi, Stefano, Hi Jason, >>> If you still want me to include the DA9053 support into fsl_pmic, >>> could you please >>> extend the fsl_pmic support to easily add another vender's pmic support first? >> >> Really I have not understood your question. What do you mean ? > > Then, Can you tell me how to add the dialog pmic support into > fsl_pmi.c file which is dedicated for > freescale mc13xxx? Thanks, IMHO the details for each Power Controllers are inside the corresponding header, that contains the register description, in your xace DA09053.h. The fsl_pmic.c expones only a general way to speak with the controller via SPI or I2C interface. If I see your patch, the only real difference with the original file is that a single byte is read/written with the DA09053, while the mc13xxx have 32-bit registers. You can add this option as CONFIG_ switch, or in another way. Only the board is aware about which PMIC is used. In fact, the fsl_pmic.c does not include neither mc13892.h nor mc13783.h. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================