From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Wed, 27 Apr 2011 10:16:29 -0300
Subject: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version
In-Reply-To: <4DB7E496.4070400@denx.de>
References: <1302574692-28134-1-git-send-email-festevam@gmail.com>	<4DA8897B.70202@denx.de>
	<4DB054C2.4020901@denx.de> <m2r58ocb39.fsf@ohwell.denx.de>
	<4DB7E496.4070400@denx.de>
Message-ID: <4DB8172D.5090601@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

On 4/27/2011 6:40 AM, Stefano Babic wrote:
...
>> but why not change get_cpu_rev to 'const char *'
>> which it actually is?
> 
> This is correct. However, I have not noted before that the last
> introduced get_cpu_rev() in MX31 is an exception in u-boot. For all
> other processors, it returns a u32 and it is defined as u32
> get_cpu_rev(void).
> 
> Fabio's patch introduces a variant, because it is defined as const char
> *get_cpu_rev(void). I propose to change its name (get_cpu_rev_string ?)
> and add the static attribute, to make clear it is different as the
> get_cpu_rev() already implemented in u-boot.

Ok, I can change it as per your suggestion.

Will send a patch soon.

Regards,

Fabio Estevam